New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InfoPanel Fixes. #1133

Merged
merged 4 commits into from Aug 17, 2017

Conversation

Projects
None yet
3 participants
@grokys
Contributor

grokys commented Aug 11, 2017

A few InfoPanel fixes:

  • Bind MarkdownViewer.Markdown in InfoPanel.xaml - the panel won't display a message if we don't bind the property!
  • Use VsBrush.InfoBackground as the background color, previously it was just Beige

Fixes #1131

@grokys grokys changed the title from Fix InfoPanel message. to InfoPanel Fixes. Aug 11, 2017

@grokys grokys requested a review from jcansdale Aug 11, 2017

@grokys grokys changed the base branch from master to release/2.3.0 Aug 11, 2017

@grokys grokys changed the base branch from release/2.3.0 to master Aug 16, 2017

grokys added some commits Aug 11, 2017

Bind MarkdownViewer.Markdown
The panel won't display a message if we don't bind the property! Fixes #1131
Fix InfoPanel background.
Use a VS brush to make it the correct color.
var url = e.Parameter.ToString();
if (!string.IsNullOrEmpty(url))
Browser.OpenUrl(new Uri(url));

This comment has been minimized.

@jcansdale

jcansdale Aug 16, 2017

Contributor

Similar to other PR. What is url is malformed?

@jcansdale

jcansdale Aug 16, 2017

Contributor

Similar to other PR. What is url is malformed?

This comment has been minimized.

@shana

shana Aug 16, 2017

Collaborator

We set the urls in the info panels, it's not from user input, so they should never be malformed. If they are and throw, we should catch that in testing (we are clicking on every infopanel that we have during testing to make sure nothing regressed, right? 😉)

@shana

shana Aug 16, 2017

Collaborator

We set the urls in the info panels, it's not from user input, so they should never be malformed. If they are and throw, we should catch that in testing (we are clicking on every infopanel that we have during testing to make sure nothing regressed, right? 😉)

@shana

shana approved these changes Aug 16, 2017

@grokys grokys merged commit f79bd44 into master Aug 17, 2017

5 checks passed

GitHub CLA @grokys has accepted the GitHub Contributor License Agreement.
Details
VisualStudio Build #7664641 succeeded in 91s
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins/build_log Jenkins Build Log
Details

@grokys grokys deleted the fixes/1131-infopanel-broken branch Aug 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment