New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ExtensionInstallationFolder #2 #1210

Merged
merged 6 commits into from Aug 31, 2017

Conversation

Projects
None yet
3 participants
@grokys
Contributor

grokys commented Aug 31, 2017

To make sure that the extension is always installed to the same directory (VS 2017 only). #990 did this originally but that wasn't merged as I thought that our issue had been resolved without it. Seems it's still needed as it's causing problems with the VS Installer.

grokys added some commits Aug 31, 2017

Updated Sdk package.
Updated `Microsoft.VisualStudio.Sdk.BuildTasks.14.0` to 14.0.215.
Set ExtensionInstallationFolder
To make sure that the extension is always installed to the same
directory.

@grokys grokys changed the title from WIP: Set ExtensionInstallationFolder #2 to Set ExtensionInstallationFolder #2 Aug 31, 2017

@grokys grokys requested review from jcansdale and shana Aug 31, 2017

@shana

This comment has been minimized.

Show comment
Hide comment
@shana

shana Aug 31, 2017

Collaborator

Heh, actually no it's not good, you need to set the flag on all build types, not just debug.

Collaborator

shana commented Aug 31, 2017

Heh, actually no it's not good, you need to set the flag on all build types, not just debug.

@grokys

This comment has been minimized.

Show comment
Hide comment
@grokys

grokys Aug 31, 2017

Contributor

Fixed!

Contributor

grokys commented Aug 31, 2017

Fixed!

Show outdated Hide outdated src/GitHub.StartPage/GitHub.StartPage.csproj
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Import Project="..\..\packages\Microsoft.VisualStudio.Sdk.BuildTasks.14.0.14.0.23-pre\build\Microsoft.VisualStudio.Sdk.BuildTasks.14.0.props" Condition="'$(VisualStudioVersion)' == '14.0' And Exists('..\..\packages\Microsoft.VisualStudio.Sdk.BuildTasks.14.0.14.0.23-pre\build\Microsoft.VisualStudio.Sdk.BuildTasks.14.0.props')" />
<Import Project="..\..\packages\Microsoft.VisualStudio.Sdk.BuildTasks.14.0.14.0.215\build\Microsoft.VisualStudio.Sdk.BuildTasks.14.0.props" Condition="Exists('..\..\packages\Microsoft.VisualStudio.Sdk.BuildTasks.14.0.14.0.215\build\Microsoft.VisualStudio.Sdk.BuildTasks.14.0.props')" />

This comment has been minimized.

@jcansdale

jcansdale Aug 31, 2017

Contributor

We'll need to keep the $(VisualStudioVersion)' == '14.0', if we want it to work in VS2015 and VS2017.

@jcansdale

jcansdale Aug 31, 2017

Contributor

We'll need to keep the $(VisualStudioVersion)' == '14.0', if we want it to work in VS2015 and VS2017.

Show outdated Hide outdated src/GitHub.VisualStudio/GitHub.VisualStudio.csproj
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
<Project DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003" ToolsVersion="14.0">
<Import Project="..\..\packages\Microsoft.VisualStudio.Sdk.BuildTasks.14.0.14.0.215\build\Microsoft.VisualStudio.Sdk.BuildTasks.14.0.props" Condition="Exists('..\..\packages\Microsoft.VisualStudio.Sdk.BuildTasks.14.0.14.0.215\build\Microsoft.VisualStudio.Sdk.BuildTasks.14.0.props')" />

This comment has been minimized.

@jcansdale

jcansdale Aug 31, 2017

Contributor

Again, we need to keep $(VisualStudioVersion)' == '14.0'. 😉

@jcansdale

jcansdale Aug 31, 2017

Contributor

Again, we need to keep $(VisualStudioVersion)' == '14.0'. 😉

Show outdated Hide outdated src/GitHub.VisualStudio/GitHub.VisualStudio.csproj
@@ -15,6 +15,7 @@
<OutputPath>..\..\build\$(Configuration)\</OutputPath>
<VsixType>v3</VsixType>
<IsProductComponent>false</IsProductComponent>
<ExtensionInstallationFolder>GitHub Extension for Visual Studio</ExtensionInstallationFolder>

This comment has been minimized.

@jcansdale

jcansdale Aug 31, 2017

Contributor

How about just GitHub? It's in the Extensions folder of Visual Studio after all. 😉

@jcansdale

jcansdale Aug 31, 2017

Contributor

How about just GitHub? It's in the Extensions folder of Visual Studio after all. 😉

Show outdated Hide outdated src/GitHub.VisualStudio/GitHub.VisualStudio.csproj
<Import Project="..\..\packages\Microsoft.VSSDK.BuildTools.15.0.26201\build\Microsoft.VSSDK.BuildTools.targets" Condition="'$(VisualStudioVersion)' == '15.0' And Exists('..\..\packages\Microsoft.VSSDK.BuildTools.15.0.26201\build\Microsoft.VSSDK.BuildTools.targets')" />
<Import Project="..\..\packages\Microsoft.VisualStudio.Sdk.BuildTasks.14.0.14.0.215\build\Microsoft.VisualStudio.Sdk.BuildTasks.14.0.targets" Condition="Exists('..\..\packages\Microsoft.VisualStudio.Sdk.BuildTasks.14.0.14.0.215\build\Microsoft.VisualStudio.Sdk.BuildTasks.14.0.targets')" />

This comment has been minimized.

@jcansdale

jcansdale Aug 31, 2017

Contributor

More $(VisualStudioVersion)' == '14.0'...

@jcansdale

jcansdale Aug 31, 2017

Contributor

More $(VisualStudioVersion)' == '14.0'...

@jcansdale

This comment has been minimized.

Show comment
Hide comment
@jcansdale

jcansdale Aug 31, 2017

Contributor

Visual Studio 2015

When installed from Visual Studio (F5):

image

When installed with AllUsers=false:

image

When installed with AllUsers=true:

image

Visual Studio 2017

When installed with AllUsers=true:

image

Tried to revert (there's no uninstall option):
image

I'm now stuck on the following when I try to open the Extensions manager:

image

Contributor

jcansdale commented Aug 31, 2017

Visual Studio 2015

When installed from Visual Studio (F5):

image

When installed with AllUsers=false:

image

When installed with AllUsers=true:

image

Visual Studio 2017

When installed with AllUsers=true:

image

Tried to revert (there's no uninstall option):
image

I'm now stuck on the following when I try to open the Extensions manager:

image

@jcansdale

This comment has been minimized.

Show comment
Hide comment
@jcansdale

jcansdale Aug 31, 2017

Contributor

I'm going to follow instructions from #1206 to try to unscramble this.

Will this happen to anyone who has been auto-updated to the previous version?

Contributor

jcansdale commented Aug 31, 2017

I'm going to follow instructions from #1206 to try to unscramble this.

Will this happen to anyone who has been auto-updated to the previous version?

@jcansdale

This comment has been minimized.

Show comment
Hide comment
@jcansdale

jcansdale Aug 31, 2017

Contributor

I've followed the recovery steps from #1206.

When I loaded VS 2017 again I got the following (which is one of our old packages):

image

When I try opening the Extensions and Updates..., I'm still seeing:

image

😭

Looks like I hit the wrong hashid:
c:\programdata\Microsoft\VisualStudio\Packages\_Instances\<hashid>\state.json dir.

It's working again now. Phew!

Contributor

jcansdale commented Aug 31, 2017

I've followed the recovery steps from #1206.

When I loaded VS 2017 again I got the following (which is one of our old packages):

image

When I try opening the Extensions and Updates..., I'm still seeing:

image

😭

Looks like I hit the wrong hashid:
c:\programdata\Microsoft\VisualStudio\Packages\_Instances\<hashid>\state.json dir.

It's working again now. Phew!

@jcansdale

This comment has been minimized.

Show comment
Hide comment
@jcansdale

jcansdale Aug 31, 2017

Contributor

When launching from VS 2017 using F5, I get the following:
image

This is an easy fix. I'll push...

When it runs, assemblies are loaded form the following locations:

image

When installed with AllUSers=false, the extension installs here:

image

It looks like ExtensionInstallationFolder is an AllUsers=true specific feature.

Contributor

jcansdale commented Aug 31, 2017

When launching from VS 2017 using F5, I get the following:
image

This is an easy fix. I'll push...

When it runs, assemblies are loaded form the following locations:

image

When installed with AllUSers=false, the extension installs here:

image

It looks like ExtensionInstallationFolder is an AllUsers=true specific feature.

@jcansdale

I've given this a beating and believe it's working as expected. LGTM. 😄

@shana shana merged commit 199108f into master Aug 31, 2017

5 checks passed

GitHub CLA @grokys has accepted the GitHub Contributor License Agreement.
Details
VisualStudio Build #7833571 succeeded in 96s
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins/build_log Jenkins Build Log
Details

@shana shana deleted the fixes/installation-folder branch Aug 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment