Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Open PR link to the selected (not active) repo on GitHub #1214
Previously the # link in the PR list wasn't taking account of the selected repo (i.e. fork or target repo). This meant that if you tried to open a PR that you'd submitted from a fork, you'd get a 404 rather than the PR you'd submitted opening. Alternatively you might get the wrong PR, if a PR/issue with the same number exists in your local repo.
For example, the link highlighted below attempts to open
This PR changes it to open the selected repo. It also moves the OpenPROnGitHub command from the View to ViewModel (with the other commands).
I'm also planning to refactor the command to use Rx for consistency with the other commands in the ViewModel.
Looks good in general, though to me opening a browser is more of a view level than a view model level concern, but we could debate this forever and never reach a conclusion.
The argument for these commands being in the view model would be to facilitate unit testing, so I'm going to request a unit test ;)