Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Enable assembly resolver to ensure that `Start Page` and other icons can be found #1220
This PR fixes a few potential issues:
The most likely scenario is when someone is using using Visual Studio 2017 (15.3) and has never used the extension before. In this case the Start Page icon next to GitHub will be blank. This is unfortunate because it's when we most want people to notice it!
The reason it doesn't appears is because
Rather than having to maintain a separate list of assemblies that might need resolving, the assembly resolver loads the
The previous implementation of the assembly resolver would resolve any assembly in the extension folder when there was a full name match. This avoided false matches, but also meant it needed to call
This implementation will only hit the disk if the assembly being resolved has a matching
changed the title from
Enable assembly resolver to ensure that `GitHub.VisualStudio.imagemanifest` icons can be found
Enable assembly resolver to ensure that `Start Page` and other icons can be found
Sep 12, 2017
@meaghanlewis, I thought a simple test plan might be useful.
It would also be good to get a VM with Visual Studio 2017 (15.2) installed on it. I'm not sure how to install older versions, but it must be possible somehow? They keep updating Visual Studio 2017 and things sometimes break.
It's possible this was also an issue on Visual Studio 2017 (15.2), but no one noticed. It requires a machine where the user hasn't been using the GitHub extension, which makes it very easy to miss! I'm very interested to see what you find...
Thanks for the testing notes
I verified this using VS2017 with versions 15.3 and VS 15.0. On a fresh install of an older version of the extension (v22.214.171.124) the GitHub icon was not present, but on updating to the most recent version of the extension (v126.96.36.199) the GitHub icon was present.
The icon is present in both 15.3 and 15.0 with a fresh install of the extension from this PR build.
Was this with VS2017 15.0? I'm hoping the icon wasn't present on 15.3 until this PR build.
@jcansdale I started with a fresh install of 15.3 and then installed the extension version
Next, I did an uninstall/reinstall of 15.3, and installed extension
Lol, it's complicated! I wouldn't be surprised if this happened with VS 15.0. Did you start with a fresh install of 15.0 or 15.3?
This is the main thing!