New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual Studio sometimes crashes after selecting Clone on Team Explorer - Connect #1247

Merged
merged 4 commits into from Oct 20, 2017

Conversation

Projects
None yet
2 participants
@jcansdale
Contributor

jcansdale commented Oct 5, 2017

Reproduced this using Visual Studio 2017 15.4.0 Preview 2.0. Not sure exactly what caused it or when it happens. Sometimes it would happen a lot.

image

It seems null can be passed to the culture argument of GroupNameFromItem. An exception is then throws from Guard.ArgumentNotNull. Since culture isn't used, the null check is redundant.

PR simply removes the null check.

@jcansdale jcansdale added the bug label Oct 5, 2017

@jcansdale jcansdale requested a review from grokys Oct 5, 2017

@grokys

grokys approved these changes Oct 20, 2017

@jcansdale jcansdale merged commit 1dd3eeb into master Oct 20, 2017

5 checks passed

GitHub CLA @jcansdale has accepted the GitHub Contributor License Agreement.
Details
VisualStudio Build #8374586 succeeded in 92s
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins/build_log Jenkins Build Log
Details

@jcansdale jcansdale deleted the fixes/culture-null branch Nov 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment