Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[Feature] Reviewing PR with submodule changes #1392
Git.exe not on PATH
Deciding what to do when updating submodules and
Visual Studio 2018 will show the following if
The current commit will show the following (it will show
I'm looking to make the message a little friendlier. The user will probably already have Git installed, so there is no need to go overboard with a solution!
Something along the lines of:
I pushed a couple of commits that clean up the sync submodules number. Here's what it looks like (with some stubbed info):
For the sake of space, I kept the action to "Sync." Could we use a tooltip that says something along the lines of "Sync [number] submodules?" I tried adding one myself, but couldn't figure out how to do it in the time I allotted for myself. (The GitHubActionLink component is based of a regular xaml button component if that's any help.)
@jcansdale I forgot if you mentioned this earlier, but we should move any errors from an action into an infobar.
A few other things I've noticed
Is this correct or should we just be showing the "Sync" button in this state? Personally I don't mind the fact that you see the other 2 disabled buttons.
Yes, I've noticed this as well. I'm hoping to add some incremental progress to give the user some idea of what's going on.
This was intentional. The idea is that "Sync" is a peer of "Push" and "Pull", but only appears when there are submodules to sync (no point cluttering the interface for no reason).
I've made some changes should should make reporting incremental progress easier. I agree we should probably address it in a separate PR and keep this one focused.
The issue that occurred when checking out #1415 has now been addressed. I checked it before updating and it successfully completed a
It now checks that Git.exe exists using WHERE and displays an error message (form a resource string) and aborts if it doesn't.
I think that's everything.
I've stopped it from blocking the main thread and changed it to use the busy spinner.
I did a spike where it where it shows progress on the status bar, which works very well but isn't ready for prime time. I'll address this in a separate PR so as not to block this one!
What do you reckon?