New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that the GitHubPaneViewModel is initalized. #1426

Merged
merged 6 commits into from Feb 8, 2018

Conversation

Projects
2 participants
@grokys
Contributor

grokys commented Jan 23, 2018

  • Renamed IGitHubToolWindowManager.ShowHomePane to ShowGitHubPane because the latter is what we call it these days
  • Make IGitHubToolWindowManager.ShowGitHubPane async to make sure that GitHubPaneViewModel.InitializeAsync has finished before passing back a refrence to the GitHubPaneViewModel
  • Make the methods that call IGitHubToolWindowManager.ShowGitHubPane void async with logging when they fail
Ensure that the GitHubPaneViewModel is initalized.
- Renamed `IGitHubToolWindowManager.ShowHomePane` to `ShowGitHubPane` because the latter is what we call it these days
- Make `IGitHubToolWindowManager.ShowGitHubPane` async to make sure that `GitHubPaneViewModel.InitializeAsync` has finished before passing back a refrence to the `GitHubPaneViewModel`
- Make the methods that call `IGitHubToolWindowManager.ShowGitHubPane` `void async` with logging when they fail

@grokys grokys requested review from shana and jcansdale Jan 23, 2018

@jcansdale

This comment has been minimized.

Contributor

jcansdale commented Jan 24, 2018

@grokys,

  • I'm finding the GitHub pane spins forever when I open VS with the pane visible:

image

  • The GitHub.ShowCurrentPullRequest command does seem to work when the GitHub pane is visible.

  • If VS is opened with the GitHub pane closed, the GitHub.ShowCurrentPullRequest command doesn't open the pane.

@grokys grokys changed the title from Ensure that the GitHubPaneViewModel is initalized. to WIP: Ensure that the GitHubPaneViewModel is initalized. Jan 29, 2018

grokys added some commits Feb 7, 2018

Ensure GitHubPane initializes view model is initialized.
When the GitHub pane is shown from VS rather than our own code, kick off an initialization of the view model. This means we can't be sure of the state of the view model's initialization so make subsequent calls to the view model async either wait for an ongoing initialization, or exit if already initialized.

@grokys grokys changed the title from WIP: Ensure that the GitHubPaneViewModel is initalized. to Ensure that the GitHubPaneViewModel is initalized. Feb 7, 2018

@grokys

This comment has been minimized.

Contributor

grokys commented Feb 7, 2018

@jcansdale could you take another look at this? It's hopefully working now.

/// Ensures that the service is initialized.
/// </summary>
/// <returns>A task that when completed indicates that the service is initialized.</returns>
/// <remarks>

This comment has been minimized.

@jcansdale

jcansdale Feb 7, 2018

Contributor

Simplying? ;-)

This comment has been minimized.

@jcansdale

jcansdale Feb 7, 2018

Contributor

Hmm, is seems I missed the line with simplying and it isn't showing up for me as an in-line comment. What's going on? 😕

@jcansdale

I did a test merge with #1396 and this is working great! Apart from the typo I didn't notice any other issues. LGTM. 😄

@grokys grokys added this to In progress in 2.4.3 Feb 8, 2018

@jcansdale

LGTM

@grokys grokys merged commit 54ef0b8 into master Feb 8, 2018

3 checks passed

GitHub CLA @grokys has accepted the GitHub Contributor License Agreement.
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

2.4.3 automation moved this from In progress to Done Feb 8, 2018

@grokys grokys deleted the fixes/githubpane-initialization branch Feb 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment