New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix navigate to editor. #1580

Merged
merged 3 commits into from Apr 10, 2018

Conversation

Projects
None yet
3 participants
@grokys
Contributor

grokys commented Apr 4, 2018

This code was accidentally removed in fa8aab8

  • Fix navigate from View Changes to editor
  • Fix navigate from View File to editor

Previously the menu option to navigate from the diff view to the file in the solution was missing from the context menu - this adds it back.

Depends on #1578
Part of #1491
Fixes #1580

Fix navigate to editor.
This code was accidentally removed in fa8aab8

@grokys grokys requested review from sguthals, meaghanlewis and jcansdale Apr 4, 2018

@grokys grokys changed the base branch from master to feature/pr-reviews-master Apr 4, 2018

@jcansdale

There was a similar issue with navigating from View File to editor. I've pushed a fix. Apart from that, this is good to go! 🎉

@jcansdale

Fixed an issue with the / separator in GetAbsolutePath. I'll keep dogfooding this build.

@meaghanlewis

This comment has been minimized.

Contributor

meaghanlewis commented Apr 4, 2018

LGTM 👍

@jcansdale jcansdale changed the base branch from feature/pr-reviews-master to feature/pr-reviews Apr 10, 2018

@jcansdale jcansdale changed the base branch from feature/pr-reviews to feature/pr-reviews-master Apr 10, 2018

@jcansdale jcansdale merged commit d74fa01 into feature/pr-reviews-master Apr 10, 2018

2 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@jcansdale jcansdale deleted the fixes/navigate-to-editor branch Apr 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment