New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Octokit.GraphQL escaping issue. #1581

Merged
merged 2 commits into from Apr 10, 2018

Conversation

Projects
None yet
3 participants
@grokys
Contributor

grokys commented Apr 4, 2018

Updates the Octokit.GraphQL package to 0.0.2-alpha.

This fixes the escaping issue at octokit/octokit.graphql.net#72.

Now PR review comments that are submitted with a " character should work!

Depends on #1580
Part of #1491

@meaghanlewis

This comment has been minimized.

Contributor

meaghanlewis commented Apr 5, 2018

LGTM!

@jcansdale jcansdale changed the base branch from feature/pr-reviews-master to feature/pr-reviews Apr 10, 2018

@jcansdale jcansdale changed the base branch from feature/pr-reviews to feature/pr-reviews-master Apr 10, 2018

@jcansdale

Looks good.

@jcansdale jcansdale merged commit 8cfef76 into feature/pr-reviews-master Apr 10, 2018

2 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@jcansdale jcansdale deleted the fixes/graphql-escaping branch Apr 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment