Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Show `Pull requests` button on status bar when there's no active PR branch #1593
This PR will show a
What it does
This means that if we're on a PR branch that hasn't yet been opened in the PR detail view (issue #1591), the
At the moment it will appear whenever there is a Git repo with a remote. This means it will also appear on a TFS Git repo. While not the end of the world (clicking on it says
Do we currently have any code that looks for GitHub-ish URLs?
TFS Git remotes seem to look like this (which would be easy to filter out):
Mitigation for #1591
Just some overall comments from our conversations today:
High Level Problem
There are three issues that we currently have:
Issues with this solution
Though the solution proposed here might resolve the friction of the above three problems, it introduces new friction in terms of design continuity and user experience expectations. Mainly:
Other Potential Solutions to the High Level Problem
I feel there are two things that need to be addressed:
Focused on solving the PR accessibility issue
If we are focused on only solving the first, I could imagine a few potential solutions:
I prefer (3), however I'm wondering what we should do if a user isn't on a PR. What should the text say?
And I'm sure many other ideas.
Focused on the GitHub pane discoverability, workflow, accessibility
I do think, with Forking, Issues, and PR Reviews we have a bigger issue that needs addressing. That is - how are we going to help users be able to discover all of our features when they need to be discovering them.