New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix avatar in inline comments. #1609

Merged
merged 1 commit into from Apr 17, 2018

Conversation

Projects
None yet
3 participants
@grokys
Contributor

grokys commented Apr 17, 2018

Don't use the default button width for the button in the avatar view. The default button width is 76; don't use this for the button in the avatar as it will likely be much smaller, and in fact was making the avatar invisible in the inline comment view.

Before:

2018-04-17_11-24-10

After:

2018-04-17_11-26-02

Don't use default button width for avatar.
The default button width is 76; don't use this for the button in the avatar as it will likely be much smaller.
@sguthals

LGTM

@meaghanlewis

This comment has been minimized.

Contributor

meaghanlewis commented Apr 17, 2018

Tested with GitHub and GitHub Enterprise. LGTM ⚡️

@grokys grokys merged commit 805c327 into master Apr 17, 2018

2 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@grokys grokys deleted the fixes/comment-avatar branch Apr 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment