New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization of GHfVS for Chinese - Simplified and Traditional #1714

Merged
merged 35 commits into from Aug 10, 2018

Conversation

Projects
None yet
5 participants
@maikebing
Contributor

maikebing commented Jun 1, 2018

Localization work started
Let's all translate together, click here to join https://crwd.in/github-visual-studio HTTPS://CRWD.IN/GITHUBVS

  • Chinese (Simplified) -

  • Chinese (Traditional) -

  • English -

- [ ] Czech
- [ ] French - 
- [ ] German -  @wenz
- [ ] Italian -  
- [ ] Japanese
- [ ] Korean
- [ ] Polish
- [ ] Portuguese (Brazil)
- [ ] Russian - 
- [ ] Spanish - 
- [ ] Turkish
@maikebing

This comment has been minimized.

Show comment
Hide comment
@maikebing

maikebing Jun 1, 2018

Contributor

#18 Localization: Localize the extension to {insert language here}

Contributor

maikebing commented Jun 1, 2018

#18 Localization: Localize the extension to {insert language here}

@maikebing

This comment has been minimized.

Show comment
Hide comment
@maikebing

maikebing Jun 3, 2018

Contributor

1
2

Contributor

maikebing commented Jun 3, 2018

1
2

@sguthals

This comment has been minimized.

Show comment
Hide comment
@sguthals

sguthals Jun 15, 2018

Contributor

Thank you @maikebing for getting this started! We're really excited to see localization in our extension! 🎉

Let us know how we can help 👍

Contributor

sguthals commented Jun 15, 2018

Thank you @maikebing for getting this started! We're really excited to see localization in our extension! 🎉

Let us know how we can help 👍

maikebing added some commits Jun 16, 2018

@maikebing

This comment has been minimized.

Show comment
Hide comment
@maikebing

maikebing Jun 21, 2018

Contributor

@sguthals GitHub context Menu I have not been able to localize, and I did not find the reason, perhaps I fell into some kind of misunderstanding. Do you know who is familiar with VSCT?

Contributor

maikebing commented Jun 21, 2018

@sguthals GitHub context Menu I have not been able to localize, and I did not find the reason, perhaps I fell into some kind of misunderstanding. Do you know who is familiar with VSCT?

@sguthals

This comment has been minimized.

Show comment
Hide comment
@sguthals

sguthals Jun 21, 2018

Contributor

Hi @maikebing!

Maybe @jcansdale or @grokys can help you out with that!

Contributor

sguthals commented Jun 21, 2018

Hi @maikebing!

Maybe @jcansdale or @grokys can help you out with that!

@grokys

This comment has been minimized.

Show comment
Hide comment
@grokys

grokys Jun 21, 2018

Contributor

Hi @maikebing - to be honest this is something I've never done either!

First of all, what have you already tried? Have you tried following the instructions at https://docs.microsoft.com/en-gb/visualstudio/extensibility/localizing-menu-commands?

Contributor

grokys commented Jun 21, 2018

Hi @maikebing - to be honest this is something I've never done either!

First of all, what have you already tried? Have you tried following the instructions at https://docs.microsoft.com/en-gb/visualstudio/extensibility/localizing-menu-commands?

maikebing added some commits Jun 24, 2018

@maikebing

This comment has been minimized.

Show comment
Hide comment
@maikebing

maikebing Jun 29, 2018

Contributor

githubchs
Hi @sguthals @grokys
The problems that have been encountered have been resolved. Please review the code? If you have any questions, please ask me.

@heku If you have time, can you reconsider the Chinese content?

Contributor

maikebing commented Jun 29, 2018

githubchs
Hi @sguthals @grokys
The problems that have been encountered have been resolved. Please review the code? If you have any questions, please ask me.

@heku If you have time, can you reconsider the Chinese content?

maikebing added some commits Jul 5, 2018

@meaghanlewis

This comment has been minimized.

Show comment
Hide comment
@meaghanlewis

meaghanlewis Aug 10, 2018

Contributor

@maikebing I'll test out this PR today.

Perhaps @grokys can review the code?

Contributor

meaghanlewis commented Aug 10, 2018

@maikebing I'll test out this PR today.

Perhaps @grokys can review the code?

@grokys

This comment has been minimized.

Show comment
Hide comment
@grokys

grokys Aug 10, 2018

Contributor

Thanks for keeping with this @maikebing! I am reviewing now. Localization is something I'm not very familiar with, so I apologise if I need to ask stupid questions ;)

Contributor

grokys commented Aug 10, 2018

Thanks for keeping with this @maikebing! I am reviewing now. Localization is something I'm not very familiar with, so I apologise if I need to ask stupid questions ;)

@grokys

This is looking great! I tested it, and though I cannot read Chinese and so can't attest to the translations, everything seems to be translated!

I've got just a few very small changes to request in the code. I know that this isn't the focus of this PR so I would be happy to make these changes myself - just let me know if you want me to do it.

Other than that, I think this looks good to merge!

@grokys

This comment has been minimized.

Show comment
Hide comment
@grokys

grokys Aug 10, 2018

Contributor

I was worried about what would happen if we add a new resource in English but there isn't a corresponding resource in the other language yet. I just tried this and it appears to fall-back to the English text, which is the best outcome we can hope for.

Contributor

grokys commented Aug 10, 2018

I was worried about what would happen if we add a new resource in English but there isn't a corresponding resource in the other language yet. I just tried this and it appears to fall-back to the English text, which is the best outcome we can hope for.

@maikebing

This comment has been minimized.

Show comment
Hide comment
@maikebing

maikebing Aug 10, 2018

Contributor

@grokys Yes , it fall-back to English .

Contributor

maikebing commented Aug 10, 2018

@grokys Yes , it fall-back to English .

maikebing added some commits Aug 10, 2018

@meaghanlewis

This comment has been minimized.

Show comment
Hide comment
@meaghanlewis

meaghanlewis Aug 10, 2018

Contributor

This looks good to me. Thanks so much @maikebing!

Contributor

meaghanlewis commented Aug 10, 2018

This looks good to me. Thanks so much @maikebing!

changes addressed!

@meaghanlewis meaghanlewis merged commit 3b501b0 into github:master Aug 10, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@meaghanlewis meaghanlewis added this to the 2.5.5 milestone Aug 10, 2018

@meaghanlewis meaghanlewis referenced this pull request Aug 10, 2018

Open

Localization of GHfVS #1858

2 of 5 tasks complete

@meaghanlewis meaghanlewis changed the title from Localization to Localization of GHfVS for Chinese - Simplified and Traditional Aug 10, 2018

grokys added a commit that referenced this pull request Aug 14, 2018

Fix akavache submodule.
#1714 incorrectly reverted the akavache submodule to an earlier version. Undo this.

@grokys grokys referenced this pull request Aug 14, 2018

Merged

Fix akavache submodule. #1861

grokys added a commit that referenced this pull request Aug 22, 2018

Revert "Merge pull request #1714 from maikebing/localization"
This reverts commit 3b501b0, reversing
changes made to d3641f4.

@grokys grokys referenced this pull request Aug 22, 2018

Merged

Revert pull request #1714 #1872

meaghanlewis added a commit that referenced this pull request Aug 22, 2018

@meaghanlewis meaghanlewis modified the milestones: 2.5.5, 2.5.6 Aug 22, 2018

@StanleyGoldman

This comment has been minimized.

Show comment
Hide comment
@StanleyGoldman

StanleyGoldman Aug 31, 2018

Contributor

Hi @maikebing!
Thank you for your help!

We tried to merge this but had some bugs.
We are trying again here in this Pull Request #1888.

I learned a lot more about CrowdIn.
I created a new CrowdIn Project and invited you: https://crwd.in/github-visual-studio
This CrowdIn Project is integrated with our GitHub Repository.

Can I ask you to resubmit your original translations in this project?

I would like to send you a private message.
I tried to send you a message on Twitter.
Should I contact you via email instead?

Contributor

StanleyGoldman commented Aug 31, 2018

Hi @maikebing!
Thank you for your help!

We tried to merge this but had some bugs.
We are trying again here in this Pull Request #1888.

I learned a lot more about CrowdIn.
I created a new CrowdIn Project and invited you: https://crwd.in/github-visual-studio
This CrowdIn Project is integrated with our GitHub Repository.

Can I ask you to resubmit your original translations in this project?

I would like to send you a private message.
I tried to send you a message on Twitter.
Should I contact you via email instead?

@maikebing

This comment has been minimized.

Show comment
Hide comment
@maikebing
Contributor

maikebing commented Aug 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment