Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent opening PR in browser multiple times. #1781

Merged
merged 1 commit into from Jul 13, 2018

Conversation

Projects
None yet
3 participants
@grokys
Copy link
Contributor

grokys commented Jul 13, 2018

When "Open in Browser" is selected in the PR list, if the user has navigated multiple times to the PR list, then multiple tabs will be opened.

Ensure the PR list unsubscribes when it is unloaded.

@grokys grokys requested a review from jcansdale Jul 13, 2018

@jcansdale
Copy link
Collaborator

jcansdale left a comment

Confirmed. Thanks for the quick fix! 🎉

@jcansdale jcansdale merged commit 1b6a9a1 into master Jul 13, 2018

2 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@jcansdale jcansdale deleted the fixes/open-pr-in-browser branch Jul 13, 2018

@meaghanlewis meaghanlewis added this to the 2.5.4 milestone Jul 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.