Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Refactored Clone Dialog #1787
Refactored the clone dialog, basing it initially on the clone dialog from desktop:
Particularly the URL clone view needs some input from @donokuda.
GraphQL requires the
Depends on #1761
In case it hasn't been considered yet, a potentially "quick & dirty" flow for this is to pop up a modal dialog on top of the clone dialog that give the individual the option to log out.
I'd imagine the flow to break down like this:
This looks great to me @grokys !
One thing that I ran into was when I wanted to enter the username and repo to clone - ex
I authenticated with it, but it didn't actually sign me in and I got an error like this
Is it possible to show our Sign in dialog here instead to avoid this from possibly confusing users?
@meaghanlewis hmm yes, I'm not quite sure how to deal with that. If the repository is publicly visible then this clone should actually work. We could make a check to see if we have a connection to the server that the clone is being requested from, but again, the clone may actually work.
I notice desktop does the same thing in this situation and shows a login dialog. I'm tempted to say that this is expected behavior.
referenced this pull request
Sep 10, 2018
One more question - could you add a message for when someone tries to clone a repo they already have?