New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Requests w/ Statuses #1788

Merged
merged 63 commits into from Aug 9, 2018

Conversation

Projects
None yet
4 participants
@StanleyGoldman
Contributor

StanleyGoldman commented Jul 19, 2018

Initially we set out to implement both the Statuses API and the Checks API, but OAuth applications do not currently have access to the Checks API and there are no major projects making use of the Statuses API.

Since Statuses are simpler Check Runs, we can implement Statuses with the anticipation of adding Check Runs.

https://developer.github.com/v3/repos/statuses/

Known issues

  • The icon will display the icon of the user that integrated the app, not the icon of the app itself
    • There is a bug in the GraphQL API where it is not possible to get the correct Application icon for Statuses. I thought I did everything for MEF to like me, but VisualStudioBrowser remains null.
    • We are waiting for API changes to make this data available
  • Trouble opening the Hyperlink from PullRequestCheckRunView
    [Import]
    IVisualStudioBrowser VisualStudioBrowser { get; set; }
    void DoOpenDetailsUrl()
    {
    var browser = VisualStudioBrowser;
    browser.OpenUrl(ViewModel.DetailsUrl);
    }

New Metrics

  • NumberOfPRDetailsOpenInGitHub: The number of times the "View on GitHub" link is clicked from a pull request detail view
  • NumberOfPRCheckStatusesOpenInGitHub: The number of times a Status API "Details" link is clicked

TODO

  • Need designs for the Checks dropdown on the PullRequestDetailsView (@donokuda)

User Interfaces

image

image

StanleyGoldman added some commits Jul 12, 2018

Merge branch 'master' into stanley/check-suites-pull-request-model-1
# Conflicts:
#	src/GitHub.VisualStudio/Views/GitHubPane/PullRequestListItemView.xaml

@StanleyGoldman StanleyGoldman added the WIP label Jul 19, 2018

@StanleyGoldman StanleyGoldman changed the title from Pull Requests w/ Checks & Suites to WIP: Pull Requests w/ Checks & Suites Jul 20, 2018

donokuda and others added some commits Jul 20, 2018

@StanleyGoldman StanleyGoldman changed the title from WIP: Pull Requests w/ Checks & Suites to Pull Requests w/ Statuses Jul 24, 2018

@StanleyGoldman StanleyGoldman removed the WIP label Jul 24, 2018

StanleyGoldman added some commits Jul 24, 2018

donokuda and others added some commits Jul 25, 2018

Merge pull request #1793 from github/donokuda/check-suites-polish
Polish check suite results in pull request list

StanleyGoldman added some commits Jul 26, 2018

Merge pull request #1808 from github/view-locator-tears
Attempting to use the view locator correctly

grokys and others added some commits Aug 7, 2018

@grokys

Pretty much there! I'm mainly nitpicking at this point ;) Also, some XML documentation might be nice for the new classes?

Show outdated Hide outdated src/GitHub.App/Models/PullRequestModel.cs
Show outdated Hide outdated src/GitHub.App/SampleData/PullRequestCheckViewModelDesigner.cs
Show outdated Hide outdated src/GitHub.VisualStudio/Views/GitHubPane/PullRequestCheckView.xaml
Show outdated Hide outdated src/GitHub.VisualStudio/Views/GitHubPane/PullRequestCheckView.xaml
Show outdated Hide outdated src/GitHub.App/Services/ModelService.cs
Show outdated Hide outdated src/GitHub.Exports/Models/StatusStateEnum.cs
@@ -42,12 +46,12 @@ public bool IsCurrent
}
/// <inheritdoc/>
public int Number { get; protected set; }
public int Number { get; }

This comment has been minimized.

@grokys

grokys Aug 8, 2018

Contributor

Thanks for fixing these :D

@grokys

grokys Aug 8, 2018

Contributor

Thanks for fixing these :D

StanleyGoldman added some commits Aug 8, 2018

@grokys

grokys approved these changes Aug 8, 2018

@grokys grokys merged commit c3acc5d into master Aug 9, 2018

2 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment