New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functionality to support Check Suites API #1798

Merged
merged 28 commits into from Aug 21, 2018

Conversation

Projects
None yet
3 participants
@StanleyGoldman
Contributor

StanleyGoldman commented Jul 24, 2018

This pull request displays a summary line for Check Runs and links a user to the Check Run page.

@StanleyGoldman StanleyGoldman added the WIP label Jul 24, 2018

@StanleyGoldman StanleyGoldman changed the base branch from master to stanley/check-suites-pull-request-model-1 Jul 24, 2018

@meaghanlewis meaghanlewis added this to the 2.5.5 milestone Jul 30, 2018

StanleyGoldman added some commits Aug 10, 2018

Merge remote-tracking branch 'origin/master' into features/check-suites
# Conflicts:
#	src/GitHub.App/Services/PullRequestService.cs
#	src/GitHub.App/ViewModels/GitHubPane/PullRequestDetailViewModel.cs
#	src/GitHub.Exports/Models/PullRequestDetailModel.cs
#	src/GitHub.InlineReviews/Services/PullRequestSessionService.cs
#	test/GitHub.App.UnitTests/ViewModels/GitHubPane/PullRequestDetailViewModelTests.cs

@StanleyGoldman StanleyGoldman changed the title from [WIP] Functionality to support Check Suites API to Functionality to support Check Suites API Aug 10, 2018

@StanleyGoldman StanleyGoldman added Ready for Review and removed WIP labels Aug 10, 2018

@StanleyGoldman StanleyGoldman changed the base branch from stanley/check-suites-pull-request-model-1 to master Aug 10, 2018

StanleyGoldman added some commits Aug 10, 2018

@StanleyGoldman StanleyGoldman requested review from grokys and jcansdale Aug 13, 2018

StanleyGoldman added some commits Aug 13, 2018

@grokys

Looks good so far! A few nits, and one requested change that I couldn't add as an inline comment:

  • Could the nupkg be removed from the lib directory now? That package is on nuget.org right?
Show outdated Hide outdated src/GitHub.App/Services/PullRequestService.cs
Show outdated Hide outdated src/GitHub.App/ViewModels/GitHubPane/PullRequestCheckViewModel.cs
/// <summary>
/// Model for a single check annotation.
/// </summary>
public class CheckRunAnnotationModel

This comment has been minimized.

@grokys

grokys Aug 14, 2018

Contributor

Nicely documented ;)

@grokys

grokys Aug 14, 2018

Contributor

Nicely documented ;)

This comment has been minimized.

@StanleyGoldman

StanleyGoldman Aug 14, 2018

Contributor

👍

@StanleyGoldman
Show outdated Hide outdated src/GitHub.Exports/Models/PullRequestDetailModel.cs

StanleyGoldman added some commits Aug 14, 2018

StanleyGoldman added some commits Aug 20, 2018

@grokys

grokys approved these changes Aug 21, 2018

@meaghanlewis

This comment has been minimized.

Show comment
Hide comment
@meaghanlewis

meaghanlewis Aug 21, 2018

Contributor

This LGTM! Thanks for your work on this @StanleyGoldman

Contributor

meaghanlewis commented Aug 21, 2018

This LGTM! Thanks for your work on this @StanleyGoldman

@StanleyGoldman StanleyGoldman merged commit 23e48d1 into master Aug 21, 2018

2 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@StanleyGoldman StanleyGoldman deleted the features/check-suites branch Aug 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment