New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install GitHub.TeamFoundation.15 MEF component in all Visual Studio versions #1831

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@jcansdale
Contributor

jcansdale commented Aug 6, 2018

It looks like c9703cd might have stopped the extension from working on some Visual Studio installations.

From the MEF log #1810 (comment), it appears the VSIX installer is attempting to install the GitHub.TeamFoundation.14 assembly on Visual Studio 2017 (and failing), but ignoring the GitHub.TeamFoundation.15 assembly.

What this PR does

  • Allow the GitHub.TeamFoundation.15 assembly to install on all Visual Studio versions

There should no change on Visual Studio 2015 which doesn't support version ranges and will attempt to install all MEF assemblies anyway.

Visual Studio 2017 should always install GitHub.TeamFoundation.15, even if an erroneous attempt has been made to install GitHub.TeamFoundation.14.

We don't know if Visual Studio 2019+ will release new TeamFoundation assemblies. If they don't, this change will allow the extension to carry on working. If they do, we will need to create a new GitHub.TeamFoundation.16 project to target them.

Update: I think this was actually an issue with a reference to Microsoft.VisualStudio.Threading v15.0

  • #1839 Reference Microsoft.VisualStudio.Threading v15.0

Fixes #1810

Install GitHub.TeamFoundation.15 for all versions
Install the GitHub.TeamFoundation.15 MEF component in all Visual Studio
versions. This is a workaround for #1810.
Use VS 15.0 version of MS.VS.Threading
Visual Studio 2017 shipped with Microsoft.VisualStudio.Threading 15.0.
Reference a version that is compatible.
@jcansdale

This comment has been minimized.

Show comment
Hide comment
@jcansdale

jcansdale Aug 7, 2018

Contributor

I think this was actually an issue with a reference to Microsoft.VisualStudio.Threading v15.0.

  • #1839 Reference Microsoft.VisualStudio.Threading v15.0
Contributor

jcansdale commented Aug 7, 2018

I think this was actually an issue with a reference to Microsoft.VisualStudio.Threading v15.0.

  • #1839 Reference Microsoft.VisualStudio.Threading v15.0

@jcansdale jcansdale closed this Aug 7, 2018

@jcansdale jcansdale deleted the fixes/1810-MEF-Asset-TargetVersion branch Aug 7, 2018

@meaghanlewis meaghanlewis added this to the 2.5.5 milestone Aug 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment