New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken build after clean or fresh clone #1929

Merged
merged 8 commits into from Sep 20, 2018

Conversation

Projects
None yet
3 participants
@jcansdale
Contributor

jcansdale commented Sep 19, 2018

What this PR does

This PR fixes the build errors after git clean -xdf or fresh clone. The main fix was moving from Microsoft.VSSDK.BuildTools.15.0.26201 to 15.8.3252.

I've also removed the old Microsoft.VisualStudio.Sdk.BuildTasks.14.0 package and hack (see #1726) to import it when launching Visual Studio 2015. This fixes some warnings but wasn't the main problem.

  • Update from Microsoft.VSSDK.BuildTools.15.0.26201 to 15.8.3252
  • Disable Threading and SDK Analyzers (need to fix errors in another PR)
  • Remove hack to import BuildTasks.14.0 when StartProgram targeting Visual Studio 2015
  • Remove legacy Sdk.BuildTasks.14.0 packages
  • Remove left over packages.config files from ` projects

How to test

  1. Clone https://github.com/github/VisualStudio
  2. Open in Visual Studio 2017
  3. Build solution

image

To confirm broken build before the update from Microsoft.VSSDK.BuildTools.15.0.26201 to 15.8.3252.

  1. git reset 9cbf07820 --hard
  2. git clean -xdf
  3. Open in Visual Studio 2017
  4. Build solution

Expect first build to fail, but later builds to pass.

Related

  • dotnet/sdk#2535: The target "VerifyTargetVersion" does not exist in the project

jcansdale added some commits Sep 19, 2018

Remove BuildTasks.14/BuildTools.15 switching
Remove the conditional logic that would switch between
BuildTasks.14/BuildTools.15 based on the target Visual Studio version
in StartProgram.
Only use the Microsoft.VSSDK.BuildTools.15.0 package.
Use same Microsoft.VSSDK.BuildTools in all .csproj
Use Microsoft.VSSDK.BuildTools.15.0.26201 in all projects.
Remove SDK and Threading Analyzers for the moment
Should restore and fix errors in another PR.

@jcansdale jcansdale changed the title from [wip] Fixes broken build after clean to Fixes broken build after clean or fresh clone Sep 19, 2018

@jcansdale jcansdale changed the title from Fixes broken build after clean or fresh clone to Fix broken build after clean or fresh clone Sep 19, 2018

Remove packages.config file for Sdk style projects
We're now using <PackageReference> for these projects.
@grokys

grokys approved these changes Sep 20, 2018

Thanks Jamie, this fixes a really annoying problem!

@grokys grokys merged commit 5e3af72 into master Sep 20, 2018

2 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@grokys grokys deleted the fixes/broken-build-after-clean branch Sep 20, 2018

@meaghanlewis meaghanlewis added this to the 2.5.6 milestone Sep 20, 2018

@meaghanlewis meaghanlewis added the bug label Sep 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment