New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package System.ValueTuple, v4.0.3.0 with VSIX #2068

Merged
merged 1 commit into from Nov 21, 2018

Conversation

Projects
None yet
3 participants
@jcansdale
Collaborator

jcansdale commented Nov 19, 2018

This is an attempted fix for #2065 and #2062.

System.ValueTuple isn't included with Visual Studio 2015 so we must include it in the VSIX. Visual Studio 2017 includes assembly version 4.0.1.0, but ReactiveUI references assembly version 4.0.3.0. We therefor need to package this assembly.

What this PR does

  • Package the assembly from System.ValueTuple, v2.5.0 NuGet (assembly version 4.0.3.0)

How to test

I think the trick will be installing a version of Windows that doesn't have .NET 4.7 installed (Windows 10 will automatically install this).

Windows version compatibility

The earliest version of Windows that Visual Studio 2017 supports is:

Windows 7 Home Premium can be found here:

The earliest version of Windows that Visual Studio 2015 works with is Windows XP, see:

Testing with Windows XP is maybe overkill? 馃槈 I guess we should decide what the lowest Windows version we want to support is?

Visual Studio 2015

  1. Install Visual Studio 2015 on Windows 7
  2. Install GitHub for Visual Studio
  • Check login dialog works

Visual Studio 2017

  1. Install Visual Studio 2017 on Windows 7
  2. Install GitHub for Visual Studio
  • Check login dialog works

User feedback

This build is working as intended. Thanks a lot!
#2062 (comment)

Was using Windows LTSB.

When I press "Connect to GitHub", the form appeared. But clicking on the tab "GitHub Enterprise" (to choose the url to our GitHub Enterprise on premise), did not work
#2065 (comment)

We think this is an unrelated issue.

No response from user on Halp.

Related

  • When i click "Connect" in the GitHub section at TeamExplorer pane, Visual Studio crashes (Halp)

Fixes #2065
Fixes #2062

@@ -414,6 +414,10 @@
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
<IncludeInVSIX>true</IncludeInVSIX>
</Content>
<Content Include="System.ValueTuple.dll">

This comment has been minimized.

@Neme12

Neme12 Nov 19, 2018

Contributor

Hm, this approach of adding the assembly to the repo seems a little odd. Why not just add the nuget package with the proper version?

This comment has been minimized.

@jcansdale

jcansdale Nov 20, 2018

Collaborator

I find the rules for when a file is actually included in the .vsix to be super confusing.

It seems like all of the following are required:

  1. Appear as Asset in .vsixmanifest
  2. Appear as Content in .csproj
  3. IncludeInVSIX=true
  4. CopyToOutputDirectory

I hoped I'd be able to simply add Assets to .vsixmanifest that point to files in the output directory. Alas this doesn't seems to work (the extra ceremony is required). 馃槙

I've updated the project to using a Link rather than including the binary. This is maybe a little better, but still not great. Let me know if you find a cleaner way!

This comment has been minimized.

@Neme12

Neme12 Nov 20, 2018

Contributor

Ah, ok. I thought adding the NuGet package would automatically include the assembly from it in the VSIX.

This comment has been minimized.

@jcansdale

jcansdale Nov 21, 2018

Collaborator

That's what I hoped as well, bit it looks like there are differences between a plain old assembly reference and a <PackageReference>. I ended up with missing assemblies when I converted TestDriven.Net to use <PackageReference> as well. 馃槩

This comment has been minimized.

@Neme12

Neme12 Dec 2, 2018

Contributor

Ah, I thought this was fixed: NuGet/Home#5899 You might want to report a bug if you still encounter this in recent versions.

@codecov

This comment has been minimized.

codecov bot commented Nov 20, 2018

Codecov Report

鉂楋笍 No coverage uploaded for pull request base (release/2.5.10@3729292). Click here to learn what that means.
The diff coverage is n/a.

@@                Coverage Diff                @@
##             release/2.5.10    #2068   +/-   ##
=================================================
  Coverage                  ?   39.31%           
=================================================
  Files                     ?      410           
  Lines                     ?    17585           
  Branches                  ?     2435           
=================================================
  Hits                      ?     6913           
  Misses                    ?    10120           
  Partials                  ?      552

@jcansdale jcansdale changed the base branch from master to release/2.5.9 Nov 20, 2018

@jcansdale jcansdale changed the base branch from release/2.5.9 to release/2.5.10 Nov 20, 2018

@grokys

grokys approved these changes Nov 21, 2018

Package System.ValueTuple, v4.0.3.0 with VSIX
System.ValueTuple isn't included with Visual Studio 2015 so we must
include it in the .vsix.
Link it from NuGet folder rather than include binary in project.

@jcansdale jcansdale force-pushed the fixes/2062-package-ValueTuple branch from 22eb520 to 858470c Nov 21, 2018

@jcansdale jcansdale merged commit 946c0db into release/2.5.10 Nov 21, 2018

0 of 2 checks passed

continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details

@jcansdale jcansdale deleted the fixes/2062-package-ValueTuple branch Nov 21, 2018

@jcansdale jcansdale restored the fixes/2062-package-ValueTuple branch Nov 21, 2018

@jcansdale jcansdale deleted the fixes/2062-package-ValueTuple branch Nov 23, 2018

drans4775 referenced this pull request Nov 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment