New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the experimental feature toggle for forking #2093

Merged
merged 6 commits into from Dec 6, 2018

Conversation

Projects
None yet
3 participants
@StanleyGoldman
Copy link
Contributor

StanleyGoldman commented Nov 30, 2018

No description provided.

@StanleyGoldman StanleyGoldman requested review from grokys and jcansdale Nov 30, 2018

@meaghanlewis meaghanlewis added this to the 2.6.0 milestone Nov 30, 2018

StanleyGoldman added some commits Dec 3, 2018

@meaghanlewis

This comment has been minimized.

Copy link
Contributor

meaghanlewis commented Dec 4, 2018

Tested this on VS2017 and 2019. Functionality wise this looks good. A couple things I noticed were:

  • when there are less than 3 organizations/users available to fork the highlight around the box extends very long
  • sometimes organizations/users available don't load or just take a really long time (>60 seconds)
@jcansdale
Copy link
Collaborator

jcansdale left a comment

Looks good. 👍 I'm looking forward to having this one available by default. 🙂

jcansdale added some commits Dec 5, 2018

@StanleyGoldman StanleyGoldman merged commit d2b35ab into master Dec 6, 2018

2 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@StanleyGoldman StanleyGoldman deleted the remove-fork-experimental-setting branch Dec 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment