Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use modern clone dialog when re-cloning a repository #2202

Merged
merged 4 commits into from Jan 29, 2019

Conversation

@jcansdale
Copy link
Collaborator

commented Jan 28, 2019

Depends on #2198

Now that the clone dialog can clone any arbitrary GitHub URL (not just ones owned by the user), we don't need a separate dialog when re-cloning a URL using the Start Page.

What this PR does

  • Use the same clone dialog when cloning a new repository or re-cloning one that has been cloned before
  • Remove the obsolete ShowReCloneDialog API and related classes

How to test

  1. Open the Start Page (click File > Start Page)
  2. Click on the GitHub button which is under Open
  3. Clone a repository
  4. Delete the repository folder (necessary to make the URL link appear)
  5. Open the Start Page (click File > Start Page)
  6. Click on the https:// link to the repository you cloned then deleted
  7. Open from GitHub dialog should appear

Fixes #2199

jcansdale added some commits Jan 28, 2019

Use modern clone/open dialog when re-cloning
Use the same open/clone dialog when cloning or re-cloning a respository
repository that has been cloned before.

@jcansdale jcansdale changed the base branch from master to fixes/2196-clone-progress Jan 28, 2019

@jcansdale jcansdale changed the base branch from fixes/2196-clone-progress to master Jan 28, 2019

@jcansdale

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 28, 2019

@prasethu I'm trying to test this PR, but the cloned URLs don't appear on the Start Page history (step 5 above). Any idea what's going on or why they might not be appearing? 😕

I was always unsure about when they were supposed to appear. I'd like to understand what's going on now so we can test it properly.

Update: I see the URL link appears when you delete the repository folder. It all makes sense now! 🙂

@grokys

grokys approved these changes Jan 28, 2019

Copy link
Contributor

left a comment

Yay for removing code!

@jcansdale jcansdale merged commit a49e5de into master Jan 29, 2019

4 checks passed

MSBuild Log 0 errors - 779 warnings
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
github.VisualStudio Build #20190128.16 succeeded
Details

@jcansdale jcansdale deleted the fixes/2199-reclone-using-new-open-clone-dialog branch Jan 29, 2019

@jcansdale jcansdale referenced this pull request Feb 11, 2019

Open

Release Notes #1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.