Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Hide resolved comments in changes tree; Indicate resolved comments on margin #2253
Previously pull request comments would be implicitly resolved when when the text near to the comment was changed. GitHub now supports comments being explicitly resolved by a user and comments becoming implicitly outdated when the text near to the comment is changed.
This pull request surfaces the
What this PR does
What this PR doesn't do
How to test
Here is what is looks like in the
Mar 5, 2019
I went and did A Thing replacing the info icon with the one built into visual studio. The result is a look and feel closer to a native infobar:
At first I was concerned about how much it popped out in the Dark Theme even though I was using the background color that we get from Visual Studio. However, I think it's okay for the following reasons:
We've diverged a bit from what I've prototyped but I think that's fine given that my prototype relied heavily on the interaction of collapsing resolved comments.
I think this is a good call.