Localize strings

src/GitHub.App/Resources.resx

@@ -177,9 +177,30 @@
   <data name="PublishToTitle" xml:space="preserve">
     <value>Publish repository to {0}</value>
   </data>
+  <data name="PullRequestCreationTitleValidatorEmpty" xml:space="preserve">
+    <value>Please enter a title for the Pull Request</value>
+  </data>
+  <data name="PullRequestSourceAndTargetBranchTheSame" xml:space="preserve">
+    <value>Source and target branch cannot be the same</value>
+  </data>
+  <data name="PullRequestSourceBranchDoesNotExist" xml:space="preserve">
+    <value>Source branch doesn't exist remotely, have you pushed it?</value>
+  </data>
   <data name="RepositoryCloneFailedNoSelectedRepo" xml:space="preserve">
     <value>No selected repository.</value>
   </data>
+  <data name="RepositoryCreationClonePathEmpty" xml:space="preserve">
+    <value>Please enter a repository path</value>
+  </data>
+  <data name="RepositoryCreationClonePathInvalid" xml:space="preserve">
+    <value>Please enter a valid path</value>
+  </data>
+  <data name="RepositoryCreationClonePathInvalidCharacters" xml:space="preserve">
+    <value>Path contains invalid characters</value>
+  </data>
+  <data name="RepositoryCreationClonePathTooLong" xml:space="preserve">
+    <value>Path too long</value>
+  </data>
   <data name="RepositoryCreationFailedAlreadyExists" xml:space="preserve">
     <value>Repository '{0}/{1}' already exists.</value>
   </data>

src/GitHub.App/ViewModels/PullRequestCreationViewModel.cs

@@ -12,6 +12,7 @@
 using GitHub.Validation;
 using GitHub.Extensions;
 using NullGuard;
+using GitHub.App;
 
 namespace GitHub.ViewModels
 {
@@ -47,15 +48,15 @@ public PullRequestCreationViewModel(IRepositoryHost repositoryHost, ISimpleRepos
 
             var titleObs = this.WhenAny(x => x.PRTitle, x => x.Value);
             TitleValidator = ReactivePropertyValidator.ForObservable(titleObs)
-                .IfNullOrEmpty("Please enter a title for the Pull Request");
+                .IfNullOrEmpty(Resources.PullRequestCreationTitleValidatorEmpty);
 
             var branchObs = this.WhenAny(
                 x => x.SourceBranch,
                 source => source.Value);
 
             BranchValidator = ReactivePropertyValidator.ForObservable(branchObs)
-                .IfTrue(x => x == null, "Source branch doesn't exist remotely, have you pushed it?")
-                .IfTrue(x => x.Name == TargetBranch.Name, "Source and target branch cannot be the same");
+                .IfTrue(x => x == null, Resources.PullRequestSourceBranchDoesNotExist)
+                .IfTrue(x => x.Name == TargetBranch.Name, Resources.PullRequestSourceAndTargetBranchTheSame);
 
             var whenAnyValidationResultChanges = this.WhenAny(
                 x => x.TitleValidator.ValidationResult,

src/GitHub.App/ViewModels/RepositoryCloneViewModel.cs

@@ -93,10 +93,10 @@ public RepositoryCloneViewModel(
                 (x, y) => x.Value);
 
             BaseRepositoryPathValidator = ReactivePropertyValidator.ForObservable(baseRepositoryPath)
-                .IfNullOrEmpty("Please enter a repository path")
-                .IfTrue(x => x.Length > 200, "Path too long")
-                .IfContainsInvalidPathChars("Path contains invalid characters")
-                .IfPathNotRooted("Please enter a valid path")
+                .IfNullOrEmpty(Resources.RepositoryCreationClonePathEmpty)
+                .IfTrue(x => x.Length > 200, Resources.RepositoryCreationClonePathTooLong)
+                .IfContainsInvalidPathChars(Resources.RepositoryCreationClonePathInvalidCharacters)
+                .IfPathNotRooted(Resources.RepositoryCreationClonePathInvalid)
                 .IfTrue(IsAlreadyRepoAtPath, Resources.RepositoryNameValidatorAlreadyExists);
 
             var canCloneObservable = this.WhenAny(

src/GitHub.App/ViewModels/RepositoryCreationViewModel.cs

@@ -76,10 +76,10 @@ public RepositoryCreationViewModel(
             browseForDirectoryCommand.Subscribe(_ => ShowBrowseForDirectoryDialog());
 
             BaseRepositoryPathValidator = ReactivePropertyValidator.ForObservable(this.WhenAny(x => x.BaseRepositoryPath, x => x.Value))
-                .IfNullOrEmpty("Please enter a repository path")
-                .IfTrue(x => x.Length > 200, "Path too long")
-                .IfContainsInvalidPathChars("Path contains invalid characters")
-                .IfPathNotRooted("Please enter a valid path");
+                .IfNullOrEmpty(Resources.RepositoryCreationClonePathEmpty)
+                .IfTrue(x => x.Length > 200, Resources.RepositoryCreationClonePathTooLong)
+                .IfContainsInvalidPathChars(Resources.RepositoryCreationClonePathInvalidCharacters)
+                .IfPathNotRooted(Resources.RepositoryCreationClonePathInvalid);
 
             var nonNullRepositoryName = this.WhenAny(
                 x => x.RepositoryName,

src/GitHub.VisualStudio.UI/Resources.resx

@@ -132,9 +132,6 @@
   <data name="browsePathButtonContent" xml:space="preserve">
     <value>Browse</value>
   </data>
-  <data name="GetStartedLink" xml:space="preserve">
-    <value>Get Started</value>
-  </data>
   <data name="couldNotConnectToGitHubText" xml:space="preserve">
     <value>Could not connect to github.com</value>
   </data>
@@ -330,4 +327,19 @@
   <data name="NotAGitRepositoryMessage" xml:space="preserve">
     <value>We couldn't find a git repository here. Open a git project or click "File -&gt; Add to Source Control" in a project to get started.</value>
   </data>
+  <data name="CreateAccountLink" xml:space="preserve">
+    <value>Create an account</value>
+  </data>
+  <data name="filterBranchesText" xml:space="preserve">
+    <value>Filter branches</value>
+  </data>
+  <data name="GetStartedLink" xml:space="preserve">
+    <value>Get Started</value>
+  </data>
+  <data name="GetStartedText" xml:space="preserve">
+    <value>Get Started</value>
+  </data>
+  <data name="SignInLink" xml:space="preserve">
+    <value>Sign In</value>
+  </data>
 </root>

src/GitHub.VisualStudio/UI/Views/LoggedOutView.xaml

@@ -6,6 +6,7 @@
                             xmlns:local="clr-namespace:GitHub.VisualStudio.UI.Views"
                             xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
                             xmlns:sampleData="clr-namespace:GitHub.SampleData;assembly=GitHub.App"
+                            xmlns:prop="clr-namespace:GitHub.VisualStudio.UI;assembly=GitHub.VisualStudio.UI"
                             xmlns:ui="clr-namespace:GitHub.UI;assembly=GitHub.UI"
                             DataContext="{Binding ViewModel}"
                             d:DesignHeight="300"
@@ -52,13 +53,13 @@
             <TextBlock
                 Margin="10,0"
                 HorizontalAlignment="Center">
-                <Hyperlink Command="{Binding SignIn}">Sign in</Hyperlink>
+                <Hyperlink Command="{Binding SignIn}"><TextBlock Text="{x:Static prop:Resources.SignInLink}"/></Hyperlink>
             </TextBlock>
 
             <TextBlock
                 Margin="10,0"
                 HorizontalAlignment="Center">
-                <Hyperlink Command="{Binding Register}">Create an account</Hyperlink>
+                <Hyperlink Command="{Binding Register}"><TextBlock Text="{x:Static prop:Resources.CreateAccountLink}"/></Hyperlink>
             </TextBlock>
         </StackPanel>
     </StackPanel>

src/GitHub.VisualStudio/UI/Views/NotAGitHubRepositoryView.xaml

@@ -41,8 +41,8 @@
         <Button HorizontalAlignment="Center"
                 Margin="0,15"
                 Style="{DynamicResource GitHubVsPrimaryActionButton}"
-                Command="{Binding Publish}">
-            Get Started
+                Command="{Binding Publish}" >
+          <TextBlock Text="{x:Static prop:Resources.GetStartedText}" />
         </Button>
     </StackPanel>
   </DockPanel>