New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModelService prevents ObjectDisposedException #742

Merged
merged 3 commits into from Dec 20, 2016

Conversation

Projects
None yet
2 participants
@StanleyGoldman
Contributor

StanleyGoldman commented Dec 14, 2016

A fix for #738 and #597
I realized I wouldn't be able to make a unit test for an exception that was being discarded.
And that's when I realized the fix might just be to "take the hint".
If the collection throws an ObjectDisposedException, simply stop trying to access it.

@shana

Looks great, just a few small nitpicks!

Show outdated Hide outdated src/GitHub.App/Services/ModelService.cs
Show outdated Hide outdated src/GitHub.App/Services/ModelService.cs
@StanleyGoldman

This comment has been minimized.

Show comment
Hide comment
@StanleyGoldman

StanleyGoldman Dec 15, 2016

Contributor

Cleaned up

Contributor

StanleyGoldman commented Dec 15, 2016

Cleaned up

@shana

shana approved these changes Dec 20, 2016

@shana shana merged commit a5c7e7c into github:master Dec 20, 2016

2 checks passed

GitHub CLA @StanleyGoldman has accepted the GitHub Contributor License Agreement.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment