New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Timer in usage tracker. #960

Merged
merged 1 commit into from May 9, 2017

Conversation

Projects
None yet
4 participants
@grokys
Contributor

grokys commented Apr 26, 2017

Use Timer instead of DispatcherTimer in usage tracker. Because TimerTick does IO, we should be running on a b/g thread.

Use Timer in usage tracker.
Use Timer instead of DispatcherTimer in usage tracker. Because
`TimerTick` does IO, we should be running on a b/g thread.

@grokys grokys requested a review from shana Apr 26, 2017

namespace GitHub.Services
{
public class UsageTracker : IUsageTracker
public sealed class UsageTracker : IUsageTracker, IDisposable

This comment has been minimized.

@jcansdale

jcansdale Apr 27, 2017

Contributor

Sealing your disposable classes? I see what you did there. 😉

@jcansdale

jcansdale Apr 27, 2017

Contributor

Sealing your disposable classes? I see what you did there. 😉

This comment has been minimized.

@grokys

grokys Apr 27, 2017

Contributor

Ha yeah, easier than implementing the disposable pattern and getting it wrong.

@grokys

grokys Apr 27, 2017

Contributor

Ha yeah, easier than implementing the disposable pattern and getting it wrong.

This comment has been minimized.

@grokys

grokys Apr 27, 2017

Contributor

Also this class is a singleton, so Dispose won't even be called.

@grokys

grokys Apr 27, 2017

Contributor

Also this class is a singleton, so Dispose won't even be called.

This comment has been minimized.

@Haacked

Haacked Apr 27, 2017

Member

LOL! I do this all the time in apps. Less so in libraries. But it's very convenient to just seal them until you need them not to be sealed. 😄

@Haacked

Haacked Apr 27, 2017

Member

LOL! I do this all the time in apps. Less so in libraries. But it's very convenient to just seal them until you need them not to be sealed. 😄

@paladique paladique merged commit 63fd51c into release/2.2.0.11 May 9, 2017

5 checks passed

GitHub CLA @grokys has accepted the GitHub Contributor License Agreement.
Details
VisualStudio Build #6396028 succeeded in 83s
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins/build_log Jenkins Build Log
Details

@paladique paladique deleted the fixes/usagetracker-tick-bg-thread branch May 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment