New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a delay to the login process. #979

Merged
merged 1 commit into from May 8, 2017

Conversation

Projects
None yet
3 participants
@grokys
Contributor

grokys commented May 4, 2017

We're getting a lot of reports of failed logins, and looking at the logs it appears that using a token immediately after it's given out can fail. Add a delay of 1s (I tried less but this seems to give the best results) before reading /user after authorization.

Add a delay to the login process.
We're getting a lot of reports of failed logins, and looking at the logs
it appears that using a token immediately after it's given out can fail.
Add a delay of 1s (I tried less but this seems to give the best results)
before reading `/user` after authorization.
@shana

shana approved these changes May 5, 2017

@shana

This comment has been minimized.

Show comment
Hide comment
@shana

shana May 5, 2017

Collaborator

triple-facepalm-no-words

Collaborator

shana commented May 5, 2017

triple-facepalm-no-words

@paladique

👍

@paladique paladique merged commit a3803a6 into release/2.2.0.11 May 8, 2017

5 checks passed

GitHub CLA @grokys has accepted the GitHub Contributor License Agreement.
Details
VisualStudio Build #6494874 succeeded in 91s
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins/build_log Jenkins Build Log
Details

@paladique paladique deleted the fixes/login-delay branch May 8, 2017

grokys added a commit that referenced this pull request Jun 12, 2017

Added retries with delays.
#979 added a delay to the login process, but when porting that to the `fixes/809-refactor-logins` branch for #845 I discovered that a single 1s delay is sometimes not enough. Trying 3 times with a 1s delay however does seem to work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment