Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Source code cut off #222

Closed
joseds opened this Issue · 16 comments

5 participants

José Diaz Seng Kevin Sawicki Will Speak Sagar Sane Patrick de Lanauze
José Diaz Seng

Hi,
thank you for adding the ability to browse source code, that's a very useful feature. I noticed that only part of the code is being displayed, I had e.g. 101 lines in one and 201 lines in another case. Is this limit perhaps character count based?
Source code browsing would not be very useful for me if such a cut–off exists. Is this a bug or is there a strong reason behind it?
José

Kevin Sawicki

Hi, there shouldn't be any limit to the amount of code being browsed.

What phone and Android version are you on?

Also, can you share the repository and path of the specific file that was cut off? Thanks.

José Diaz Seng

Hi, I am using a Samsung Galaxy Nexus with the current Android version (4.1.1). I just noticed a funny thing: The phone was in portrait orientation when opening a source code file and I could see 101 lines. When I had scrolled to the last line and tilted the phone to landscape mode, 101 more lines did appear. Thus, by scrolling to the end and switching orientation repeatedly, I could see the whole contents.

One of the files I browsed is one in a private repository, namely the file joseds/DBIx-Table-TestDataGenerator/lib/Table/DBIx/TestDataGenerator.pm I don't know if you have access to it, otherwise I could put it in a public repository. But my guess is that it has nothing to do with the specific file. Thanks!

Kevin Sawicki

Definitely sounds like a bug, will try reproducing and see about upgrading the CodeMirror
version used for source code viewing.

Will Speak

I have noticed this bug too, but only on private repository files. Always at 101 lines.

It may be related that there seems to be a line lenght limit too. No matter how far you zoom out.

Code hilighting does not seem to be triggered on these files either.

Kevin Sawicki

@iwillspeak what programming language is the file that you saw the issue in? Or is it all private repository files?

Sagar Sane

Hello,
It happens for me too. Specifically, here is the case:

I went to this repo -- not private repo.

And viewed the file SpotifyControl.scpt. At first I can see only 101 lines. But, if you zoom out or zoom in (by just one tap, either way). I start seeing the remaining lines 126 in this case. Thus it seems it works if you zoom out/in at least once.

Its Samsung Galaxy S Gingerbread in my case.

For other files, like a long Python file, at first. I can see only 101 lines, but then it loads up the remaining lines of code once I hit the bottom of screen (bottom of the first 101 lines).

Thank you.
Sagar

Kevin Sawicki

@sagarsane Thanks, I was able to reproduce with the repo and file you mentioned.

I pushed the fix mentioned in this issue in the CodeMirror lib.

I'll cut a release early next week after some more testing.

Sagar Sane

Cool! Thanks @kevinsawicki !

Will Speak
José Diaz Seng

Thank you @kevinsawicki for taking care of this!

Kevin Sawicki

The 1.4 release with this fix is now available in Google Play.

Please let me know if you still see it or other source rendering bugs after upgrading.

Thanks again for reporting this and providing all the details.

Will Speak

I have updated but noticed that although there is no longer a cut off at 101 lines there now appears to be one at 202.

Patrick de Lanauze

I just noticed one at line 600.. Java script file, shows 600 lines out of 702..

Patrick de Lanauze

So the file loads fine in portait orientation, but in landscape I see a cutoff.
Running 4.1.2 gt-n7000 with github 1.5

Kevin Sawicki

@pdelanauze Is the file being cut off in a public repo that you can share a link to?

Patrick de Lanauze
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.