Support filtering the repositories page list #657
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This required a bit of reworking of the adapters to use a list instead of an array and that changed the signature of the base class constructor which required updates to all list adapters even those unaffected by the addition of repository filtering. ps: A continuation work based on original @kevinsawicki filtering branch. Support filtering the repositories page list Add view to support filtering Replace SingleTypeAdapter with ItemListAdapter to support filtering Apply NewsListAdapter Add view to support filtering Add edit and delete button Replace import R.* with import R Replace SingleTypeAdapter with ItemListAdapter for filtering Change array to List Add view to support filtering Replace R.* with R Replace SingleTypeAdapter with ItemListAdapter to support filtering Replace SingleTypeAdapter with ItemListAdapter to support filtering Add find a repository Apply ItemListAdapter to support filtering Add filtering Add support for filtering Add view to support filtering Replace R.* with R Add updateComments Add support for filtering Add filtering Add view to support filtering Support filtering the repositories page list Add filtering Add filtering Add view to support filtering Add filtering in issue-related items Add view to support filteringin repo-related items Add filtering for repository page list Add filtering for searched repositories Add filtering for user's repo page list Add view for commit filtering Refactor variable name Add filtering for commit page list Fix error to support filtering Add filtering for issue page list Add view for contributor's filtering Add filtering in contributor's page list Add view for searched user filtering Add filtering for searched user page list Add filtering for user page list Add view for user page list filtering Add filtering for members page list Add filtering Add pull to refresh Fix for filtering features Add filtering for repo page list Fix nullPointerException on authorView
|
@jonanp Can we merge this? Or is it still under your review? |
|
You should update your IDE's copyright template ;) |
|
What about it? |
|
The new files here all say Copyright (c) Github 2012 |
|
Good catch. Thanks. |
|
@fadils I'm still reviewing and I think I have some issues, I'll give you more details soon. |
|
@jonanp Will wait for the feedbacks. |
|
@hzsweers probably need to resolve many conflicts before it can be merged once again. Let's set this to the release after the first one. But before continueing this thing, was wondering what feedbacks @jonan is going to give. It will be useful to get his feedback, then continue the development. |
|
closed via #796 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A continuation work based on original @kevinsawicki filtering branch..
cc'ed @jonanp @atermenji