Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EPL-2.0 #554

Merged
merged 4 commits into from Dec 29, 2017
Merged

Add EPL-2.0 #554

merged 4 commits into from Dec 29, 2017

Conversation

mlinksva
Copy link
Contributor

Fixes #536

Two things needed for this to be merged:

  1. 2 more 'using' examples with unmodified license files (that would be detected by licensee, thus are easy to copy examples) -- help finding those wanted, thanks!
  2. SPDX to publish an official ID for the license on its website (note the approval test is failing, but that's because the test looks up OSI approval from SPDX records; that will succeed when the SPDX publishes)

@yanalunaterra
Copy link

yanalunaterra commented Nov 25, 2017

Mind that the original EPL-2.0 text file doesn't end with a newline:

@@ -306,4 +274,4 @@
   file in a relevant directory) where a recipient would be likely to
   look for such a notice.
 
-  You may add additional accurate notices of copyright ownership.
+  You may add additional accurate notices of copyright ownership.
\ No newline at end of file

how: Create a text file (typically named LICENSE or LICENSE.txt) in the root of your source code and copy the text of the license into the file.

using:
- Eclipse SmartHome: https://github.com/eclipse/smarthome/blob/master/LICENSE
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This question applies to all license metadata: why not reference the exact revision, i.e. https://github.com/eclipse/smarthome/blob/36c9e2717e4f89cf60a0d885e7ecc6069b338f48/LICENSE? That way, if the project ever gets relicensed (say, updated to EPL-3.0), the link won't go stale.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

… why not reference the exact revision…

+1 to that. It would be even nicer to reference a tagged release (e.g. once SmartHome cuts 0.9.0). As consumers are updated to use different licenses, I expect them to be removed from using. But still, where stable links are easy, I think we should be using them instead of floating with master.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #555 for a different idea.

@yanalunaterra
Copy link

yanalunaterra commented Nov 25, 2017

Also, just in case if it matches the criteria of notability (probably not), here's my JSON encoder/decoder in Erlang licensed under EPL-2.0: https://github.com/yegortimoshenko/json

@mlinksva mlinksva merged commit 8cac9c3 into gh-pages Dec 29, 2017
@mlinksva mlinksva deleted the epl-2.0 branch December 29, 2017 23:22
mlinksva added a commit that referenced this pull request Jun 22, 2018
line should've been removed rather than modified in #554
KOLANICH pushed a commit to KOLANICH-datasets/GitHub_licenses_dataset that referenced this pull request Mar 2, 2021
line should've been removed rather than modified in github/choosealicense.com#554
KOLANICH pushed a commit to KOLANICH-datasets/GitHub_licenses_dataset that referenced this pull request Mar 2, 2021
line should've been removed rather than modified in github/choosealicense.com#554
KOLANICH pushed a commit to KOLANICH-datasets/GitHub_licenses_dataset that referenced this pull request Mar 2, 2021
line should've been removed rather than modified in github/choosealicense.com#554
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants