-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Fix some licenses substitutions #583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I don't know why Travis CI build failed. All fails in "cc-by-4.0", not in edited files. |
Actualize CC-BY licenses names https://creativecommons.org/licenses/by/4.0/legalcode
I'm actualize CC-BY licenses names. Now Travis CI Build is passed |
The text in the Apache 2.0 appendix is not intended to be substituted in The CC names were corrected in SPDX license list 3.1 which was recently released, see spdx/license-list-XML#618 ... thanks for updating so that tests pass. I'll cherry-pick your fix in a new PR. |
@mlinksva do you think it would be helpful to include that information in the usage notes / how to apply section for the Apache 2.0 license? In particular, is it acceptable to omit the appendix from the license file? (That would be the opposite of #558, btw.) I'm asking because PDF.js, one of the example projects using this license, does so in their LICENSE file. |
@waldyrious yes it is acceptable (and licensee accounts for that by stripping text after "end of terms and conditions"; a test). I'm ambivalent about adding to the usage notes as I'd rather not cause people to think about modifying the license texts at all, but I could see doing it for Apache 2.0 given the occasional misunderstanding about use of the appendix as a license file. Feel free to make a PR. |
Thanks for the clarification. I'll give it a shot. |
Github use some substitutions in license text:
[year]
-- current year.[fullname]
-- name of repository owner.Apache 2.0 and ECL 2.0 licenses contains this wrong substitutions:
[yyyy] [name of copyright owner]
. Many people forget fix it manually. For example, yapf.