Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix full reference link example #157

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@johelegp
Copy link

commented May 14, 2019

According to the introducing text, this example "illustrate[s] the precedence of link text grouping over emphasis grouping." The added * makes it look like an emphasis.

@kivikakk

This comment has been minimized.

Copy link
Member

commented May 15, 2019

I'll open this upstream, as it comes from the base CommonMark spec.

@johelegp

This comment has been minimized.

Copy link
Author

commented May 15, 2019

Shall I do that in the future?

kivikakk added a commit to kivikakk/commonmark-spec that referenced this pull request May 15, 2019

@kivikakk

This comment has been minimized.

Copy link
Member

commented May 15, 2019

Here it is: commonmark/commonmark-spec#584.

Shall I do that in the future?

If it's part of the base spec, yes please! If it relates to a GFM extension, then here is the correct place 👍

jgm added a commit to commonmark/commonmark-spec that referenced this pull request May 15, 2019

@kivikakk

This comment has been minimized.

Copy link
Member

commented May 15, 2019

Upstream has committed your change! Spec changes have been merged in 4b6ceb6. Thank you!

@kivikakk kivikakk closed this May 15, 2019

@johelegp johelegp deleted the johelegp:full_reference_link branch May 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.