From 5c96c5ca3ca67dbe357fa6af430666c1d3f8d99b Mon Sep 17 00:00:00 2001 From: Chris Gavin Date: Fri, 21 Aug 2020 14:35:27 +0100 Subject: [PATCH] Use HTTP status constants in tests. --- internal/pull/pull_test.go | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/internal/pull/pull_test.go b/internal/pull/pull_test.go index 2585909..3ab3acd 100644 --- a/internal/pull/pull_test.go +++ b/internal/pull/pull_test.go @@ -123,18 +123,18 @@ func TestPullReleases(t *testing.T) { temporaryDirectory := test.CreateTemporaryDirectory(t) githubTestServer, githubURL := test.GetTestHTTPServer(t) githubTestServer.HandleFunc("/api/v3/repos/github/codeql-action/releases/tags/some-codeql-version-on-main", func(response http.ResponseWriter, request *http.Request) { - test.ServeHTTPResponseFromFile(t, 200, "./pull_test/api/release-some-codeql-version-on-main.json", response) + test.ServeHTTPResponseFromFile(t, http.StatusOK, "./pull_test/api/release-some-codeql-version-on-main.json", response) }) githubTestServer.HandleFunc("/api/v3/repos/github/codeql-action/releases/assets/1", func(response http.ResponseWriter, request *http.Request) { require.Equal(t, "application/octet-stream", request.Header.Get("accept")) - test.ServeHTTPResponseFromFile(t, 200, "./pull_test/api/asset-some-codeql-version-on-main.bin", response) + test.ServeHTTPResponseFromFile(t, http.StatusOK, "./pull_test/api/asset-some-codeql-version-on-main.bin", response) }) githubTestServer.HandleFunc("/api/v3/repos/github/codeql-action/releases/tags/some-codeql-version-on-v1-and-v2", func(response http.ResponseWriter, request *http.Request) { - test.ServeHTTPResponseFromFile(t, 200, "./pull_test/api/release-some-codeql-version-on-v1-and-v2.json", response) + test.ServeHTTPResponseFromFile(t, http.StatusOK, "./pull_test/api/release-some-codeql-version-on-v1-and-v2.json", response) }) githubTestServer.HandleFunc("/api/v3/repos/github/codeql-action/releases/assets/2", func(response http.ResponseWriter, request *http.Request) { require.Equal(t, "application/octet-stream", request.Header.Get("accept")) - test.ServeHTTPResponseFromFile(t, 200, "./pull_test/api/asset-some-codeql-version-on-v1-and-v2.bin", response) + test.ServeHTTPResponseFromFile(t, http.StatusOK, "./pull_test/api/asset-some-codeql-version-on-v1-and-v2.bin", response) }) pullService := getTestPullService(t, temporaryDirectory, initialActionRepository, githubURL) err := pullService.pullGit(true) @@ -150,14 +150,14 @@ func TestPullReleases(t *testing.T) { require.NoError(t, err) githubTestServer, githubURL = test.GetTestHTTPServer(t) githubTestServer.HandleFunc("/api/v3/repos/github/codeql-action/releases/tags/some-codeql-version-on-main", func(response http.ResponseWriter, request *http.Request) { - test.ServeHTTPResponseFromFile(t, 200, "./pull_test/api/release-some-codeql-version-on-main.json", response) + test.ServeHTTPResponseFromFile(t, http.StatusOK, "./pull_test/api/release-some-codeql-version-on-main.json", response) }) githubTestServer.HandleFunc("/api/v3/repos/github/codeql-action/releases/tags/some-codeql-version-on-v1-and-v2", func(response http.ResponseWriter, request *http.Request) { - test.ServeHTTPResponseFromFile(t, 200, "./pull_test/api/release-some-codeql-version-on-v1-and-v2.json", response) + test.ServeHTTPResponseFromFile(t, http.StatusOK, "./pull_test/api/release-some-codeql-version-on-v1-and-v2.json", response) }) githubTestServer.HandleFunc("/api/v3/repos/github/codeql-action/releases/assets/2", func(response http.ResponseWriter, request *http.Request) { require.Equal(t, "application/octet-stream", request.Header.Get("accept")) - test.ServeHTTPResponseFromFile(t, 200, "./pull_test/api/asset-some-codeql-version-on-v1-and-v2.bin", response) + test.ServeHTTPResponseFromFile(t, http.StatusOK, "./pull_test/api/asset-some-codeql-version-on-v1-and-v2.bin", response) }) pullService = getTestPullService(t, temporaryDirectory, initialActionRepository, githubURL) err = pullService.pullReleases()