Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a better error message for users of CodeQL CLI 2.7.2 and earlier running on ubuntu-22.04 #1334

Merged
merged 5 commits into from Nov 1, 2022

Conversation

henrymercer
Copy link
Contributor

@henrymercer henrymercer commented Oct 28, 2022

Improves the error message for users running (a) CLI 2.7.2 and earlier and (b) ubuntu-22.04, to which ubuntu-latest is now being migrated. Previously this was "undefined symbol: __libc_dlopen_mode, version GLIBC_PRIVATE". Now we give some guidance around glibc versions and using the ubuntu-20.04 runner image.

Example workflow run with error: https://github.com/github/codeql-action/actions/runs/3347488560/jobs/5545531438

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

Improves the error message for users running (a) CLI 2.7.2 and earlier
and (b) `ubuntu-22.04`, to which `ubuntu-latest` is now being migrated.
Previously this was "undefined symbol: __libc_dlopen_mode, version
GLIBC_PRIVATE".
Now we give some guidance around glibc versions and using the
`ubuntu-20.04` runner image.
@henrymercer henrymercer marked this pull request as ready for review October 28, 2022 18:05
@henrymercer henrymercer requested a review from a team as a code owner October 28, 2022 18:05
@henrymercer henrymercer changed the title Add a better error message for users of CodeQL CLI 2.7.2 and earlier Add a better error message for users of CodeQL CLI 2.7.2 and earlier running on ubuntu-22.04 Oct 28, 2022
src/codeql.ts Show resolved Hide resolved
src/codeql.ts Outdated Show resolved Hide resolved
src/codeql.ts Show resolved Hide resolved
@henrymercer henrymercer merged commit cd983e7 into main Nov 1, 2022
306 checks passed
@henrymercer henrymercer deleted the henrymercer/better-error-for-glibc branch November 1, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants