Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry: send event report times as ISO strings #1751

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

angelapwen
Copy link
Contributor

@angelapwen angelapwen commented Jul 5, 2023

I found in the debug logs of my test run of the new event_report fields that the request was malformed due to the started_at and completed_at timestamps being sent as strings rather than ISO strings. There was no impact to any users as the feature flag this change was behind was off for all actors.

This change simply updates the timestamps so that they are sent with the appropriate type.

This time I have validated with test runs (links internally only): run 1, run 2 with debug logging and confirmed that I did not get an API error.

I also ran the query @esbena ran on the data warehouse and confirmed that we get 2 event_reports with length 1.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@angelapwen angelapwen marked this pull request as ready for review July 5, 2023 09:20
@angelapwen angelapwen requested a review from a team as a code owner July 5, 2023 09:20
@angelapwen angelapwen requested a review from esbena July 5, 2023 09:20
@angelapwen angelapwen merged commit e960e48 into github:main Jul 5, 2023
655 checks passed
@angelapwen angelapwen deleted the fix-event-report-datetime branch July 5, 2023 10:28
@github-actions github-actions bot mentioned this pull request Jul 6, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants