Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++: introduce automatic installation of dependencies in the autobuilder #1889

Merged
merged 6 commits into from
Sep 21, 2023

Conversation

redsun82
Copy link
Contributor

@redsun82 redsun82 commented Sep 18, 2023

This introduces the possibility to automatically install dependencies when running the C++ autobuilder on an Ubuntu runner, that will be available with upcoming version 2.15.0. This behaviour can be explicitly requested by setting CODEQL_EXTRACTOR_CPP_AUTOINSTALL_DEPENDENCIES in the autobuild action env, or is otherwise driven by the code_scanning_cpp_dependency_installation feature flag.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@redsun82 redsun82 force-pushed the redsun82/cpp-autoinstall-dependencies branch from 242362a to 1dc6288 Compare September 18, 2023 09:00
src/autobuild.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it will do the right thing, though I have a couple of questions about whether we can simplify the experience by reducing the amount of configuration options. Let me know what you think!

autobuild/action.yml Outdated Show resolved Hide resolved
src/autobuild.ts Outdated Show resolved Hide resolved
src/autobuild.ts Outdated Show resolved Hide resolved
src/feature-flags.ts Show resolved Hide resolved
src/autobuild.ts Outdated Show resolved Hide resolved
src/autobuild.ts Fixed Show fixed Hide fixed
This introduces the possibility to automatically install dependencies
when running the C++ autobuilder on an Ubuntu runner, that will be
available with upcoming version 2.15.0.

An experimental `cpp-autoinstall-dependencies` input is added to the
`autobuild` action. When not set, the default is driven by a feature
flag.
@redsun82 redsun82 force-pushed the redsun82/cpp-autoinstall-dependencies branch from 6de7ce6 to 765807b Compare September 20, 2023 12:08
@redsun82 redsun82 marked this pull request as ready for review September 20, 2023 13:51
@redsun82 redsun82 requested a review from a team as a code owner September 20, 2023 13:52
henrymercer
henrymercer previously approved these changes Sep 21, 2023
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions around logging, but LGTM otherwise!

src/autobuild.ts Outdated Show resolved Hide resolved
src/autobuild.ts Outdated Show resolved Hide resolved
src/autobuild.ts Outdated Show resolved Hide resolved
Co-authored-by: Henry Mercer <henry.mercer@me.com>
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@redsun82 redsun82 merged commit 49aaa9a into main Sep 21, 2023
353 checks passed
@redsun82 redsun82 deleted the redsun82/cpp-autoinstall-dependencies branch September 21, 2023 14:49
@github-actions github-actions bot mentioned this pull request Sep 27, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants