Skip to content

Conversation

@mbg
Copy link
Member

@mbg mbg commented Nov 26, 2025

This occasionally caused weird results if the collection was triggered as well as some of the workflows in it, due to them ending up with the same concurrency group.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Environments:

  • Testing/None - This change does not impact any CodeQL workflows in production.

How did/will you validate this change?

  • End-to-end tests - I am depending on PR checks (i.e. tests in pr-checks).

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix.

How will you know if something goes wrong after this change is released?

N/A

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

Copilot AI review requested due to automatic review settings November 26, 2025 10:29
@mbg mbg requested a review from a team as a code owner November 26, 2025 10:29
@github-actions github-actions bot added the size/XS Should be very easy to review label Nov 26, 2025
Copilot finished reviewing on behalf of mbg November 26, 2025 10:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the push trigger from workflow collections to prevent concurrency conflicts when both a collection workflow and individual workflows within it are triggered simultaneously, as they would share the same concurrency group.

Key changes:

  • Modified the workflow generation script to exclude push triggers from collection workflows
  • Updated the generated __go.yml workflow collection file to reflect this change

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
pr-checks/sync.py Removes push trigger configuration from the workflow collection generation logic (lines 359-363)
.github/workflows/__go.yml Generated file reflecting the removal of push trigger from the go workflow collection

@mbg mbg enabled auto-merge November 26, 2025 10:37
@mbg mbg merged commit 7850b1c into main Nov 26, 2025
247 checks passed
@mbg mbg deleted the mbg/ci/remove-push-from-groups branch November 26, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Should be very easy to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants