Skip to content

Conversation

@mbg
Copy link
Member

@mbg mbg commented Nov 28, 2025

This brings the CodeQL workflow in line with other PR checks. The CodeQL workflow is required by the branch protection rule for main, but may not trigger if a PR originally targeted a non-main branch and the target branch subsequently changes (e.g. because the targeted branch was merged into main).

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Environments:

  • Testing/None - This change does not impact any CodeQL workflows in production.

How did/will you validate this change?

CI

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix.

How will you know if something goes wrong after this change is released?

N/A

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

@mbg mbg self-assigned this Nov 28, 2025
Copilot AI review requested due to automatic review settings November 28, 2025 09:15
@mbg mbg requested a review from a team as a code owner November 28, 2025 09:15
@github-actions github-actions bot added the size/XS Should be very easy to review label Nov 28, 2025
Copilot finished reviewing on behalf of mbg November 28, 2025 09:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the branch filter from the pull_request trigger in the CodeQL workflow to align it with other PR checks and ensure the workflow runs on all pull requests regardless of the target branch.

Key changes:

  • Removes branches: [main, releases/v*] restriction from the pull_request trigger in the CodeQL workflow

@mbg mbg merged commit ecec1f8 into main Nov 28, 2025
248 checks passed
@mbg mbg deleted the mbg/ci/run-codeql-on-all-prs branch November 28, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Should be very easy to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants