From 0e67100cadbf151ab28bb725c6cde18232d21a61 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nora=20Dimitrijevi=C4=87?= Date: Thu, 3 Nov 2022 15:30:04 +0100 Subject: [PATCH] Swift: fix bad join order in WebView/JsExportedSource The `getName = getName` join was happening too early, before the methods themselves have been enumerated. --- .../ql/lib/codeql/swift/frameworks/StandardLibrary/WebView.qll | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/swift/ql/lib/codeql/swift/frameworks/StandardLibrary/WebView.qll b/swift/ql/lib/codeql/swift/frameworks/StandardLibrary/WebView.qll index 18ae8efe99f1..84a965cba317 100644 --- a/swift/ql/lib/codeql/swift/frameworks/StandardLibrary/WebView.qll +++ b/swift/ql/lib/codeql/swift/frameworks/StandardLibrary/WebView.qll @@ -118,7 +118,7 @@ private class JsExportedSource extends RemoteFlowSource { adopter.getEnclosingDecl() instanceof JsExportedType | this.(DataFlow::ParameterNode).getParameter().getDeclaringFunction() = adopter and - adopter.getName() = base.getName() + pragma[only_bind_out](adopter.getName()) = pragma[only_bind_out](base.getName()) ) or exists(FieldDecl adopter, FieldDecl base |