Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++: More tests for cpp/use-after-free #17055

Merged
merged 2 commits into from
Jul 24, 2024
Merged

C++: More tests for cpp/use-after-free #17055

merged 2 commits into from
Jul 24, 2024

Conversation

geoffw0
Copy link
Contributor

@geoffw0 geoffw0 commented Jul 23, 2024

More tests for cpp/use-after-free. This was a second failed attempt to reproduce an issue I've seen once in the wild. I'm going to cut my losses here.

@geoffw0 geoffw0 added the C++ label Jul 23, 2024
@geoffw0 geoffw0 requested a review from a team as a code owner July 23, 2024 17:06
@geoffw0 geoffw0 added the no-change-note-required This PR does not need a change note label Jul 23, 2024
MathiasVP
MathiasVP approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Note that the FP may have been fixed by #16749

@geoffw0 geoffw0 merged commit 741a328 into github:main Jul 24, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathiasVP MathiasVP MathiasVP approved these changes

Assignees
No one assigned
Labels
C++ no-change-note-required This PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@geoffw0 @MathiasVP