From 7e14e2a950752d0e214e92ae0a277d1589d26b77 Mon Sep 17 00:00:00 2001 From: Ziemowit Laski Date: Tue, 24 Sep 2019 17:52:34 -0700 Subject: [PATCH 1/2] [zlaski/what-buffer-function] Rename references to `BufferFunction` to `ArrayFunction`. --- .../src/semmle/code/cpp/models/interfaces/ArrayFunction.qll | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cpp/ql/src/semmle/code/cpp/models/interfaces/ArrayFunction.qll b/cpp/ql/src/semmle/code/cpp/models/interfaces/ArrayFunction.qll index 59b96d7eddfc..5d63b0a9196a 100644 --- a/cpp/ql/src/semmle/code/cpp/models/interfaces/ArrayFunction.qll +++ b/cpp/ql/src/semmle/code/cpp/models/interfaces/ArrayFunction.qll @@ -1,9 +1,9 @@ /** * Provides an abstract class for accurate modeling of input and output buffers * in library functions when source code is not available. To use this QL - * library, create a QL class extending `BufferFunction` with a characteristic + * library, create a QL class extending `ArrayFunction` with a characteristic * predicate that selects the function or set of functions you are trying to - * model. Within that class, override the predicates provided by `BufferFunction` + * model. Within that class, override the predicates provided by `ArrayFunction` * to match the flow within that function. Finally, add a private import * statement to `CustomModels.qll` */ From a6d619cfe1f44f3d89808c58041d1fd0ba5adc6d Mon Sep 17 00:00:00 2001 From: Ziemowit Laski Date: Tue, 24 Sep 2019 18:17:34 -0700 Subject: [PATCH 2/2] [zlaski/what-buffer-function] Rename `CustomModels` to `Models` --- cpp/ql/src/semmle/code/cpp/models/interfaces/ArrayFunction.qll | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpp/ql/src/semmle/code/cpp/models/interfaces/ArrayFunction.qll b/cpp/ql/src/semmle/code/cpp/models/interfaces/ArrayFunction.qll index 5d63b0a9196a..cb4c531ebecf 100644 --- a/cpp/ql/src/semmle/code/cpp/models/interfaces/ArrayFunction.qll +++ b/cpp/ql/src/semmle/code/cpp/models/interfaces/ArrayFunction.qll @@ -5,7 +5,7 @@ * predicate that selects the function or set of functions you are trying to * model. Within that class, override the predicates provided by `ArrayFunction` * to match the flow within that function. Finally, add a private import - * statement to `CustomModels.qll` + * statement to `Models.qll` */ import semmle.code.cpp.Function