Java: Fix broken performance. #20380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes performance issues in the ConfusingOverloading.ql query that were introduced in a previous change. The fix addresses two specific performance problems: a join-on-index issue and incorrect use of magic optimization.
- Added
pragma[only_bind_into]annotations to prevent join-on-index performance problems - Added
pragma[nomagic]annotation to thepotentiallyConfusingTypespredicate to fix bad magic optimization
IdrissRio
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance of
ConfusingOverloading.qlwas broken by #20116. This PR fixes things. There were two issues: the dreaded join-on-index and a case of bad magic.