From c6adc51220b32cd4b5139a470596861fe7e43424 Mon Sep 17 00:00:00 2001 From: Anders Schack-Mulligen Date: Mon, 8 Sep 2025 08:30:07 +0200 Subject: [PATCH] Java: Fix broken performance. --- .../Naming Conventions/ConfusingOverloading.ql | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/java/ql/src/Violations of Best Practice/Naming Conventions/ConfusingOverloading.ql b/java/ql/src/Violations of Best Practice/Naming Conventions/ConfusingOverloading.ql index ed492e5b6a1e..0a1e8785b4ec 100644 --- a/java/ql/src/Violations of Best Practice/Naming Conventions/ConfusingOverloading.ql +++ b/java/ql/src/Violations of Best Practice/Naming Conventions/ConfusingOverloading.ql @@ -66,8 +66,8 @@ private predicate candidateMethod(RefType t, Method m, string name, int numParam predicate paramTypePair(Type t1, Type t2) { exists(Method n, Method m, int i | overloadedMethodsMostSpecific(n, m) and - t1 = n.getParameterType(i) and - t2 = m.getParameterType(i) + t1 = n.getParameterType(pragma[only_bind_into](i)) and + t2 = m.getParameterType(pragma[only_bind_into](i)) ) } @@ -93,6 +93,7 @@ predicate potentiallyConfusingTypesRefTypes(RefType t1, RefType t2) { } // then check hasSubtypeOrInstantiation +pragma[nomagic] predicate potentiallyConfusingTypes(Type t1, Type t2) { potentiallyConfusingTypesSimple(t1, t2) or