C#: Deprecate cs/captured-foreach-variable.
#20401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelnebel
force-pushed
the
csharp/deprecatecapturedforeachvariable
branch
from
21e98ca to
186e42b
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR deprecates the C# query cs/captured-foreach-variable which detected issues with capturing foreach variables in lambdas. The deprecation is warranted since C# version 5 stabilized the semantics of capturing foreach variables, making this query obsolete for modern C# development.
Key changes:
- Added deprecation documentation explaining the rationale
- Marked the query as deprecated with appropriate JSDoc annotation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| csharp/ql/src/change-notes/2025-09-10-deprecate-foreach-capture.md | Documents the deprecation of the foreach capture query |
| csharp/ql/src/Language Abuse/ForeachCapture.ql | Adds @deprecated annotation to the query header |
michaelnebel
changed the title
cs/captured-foreach-variable.
hvitved
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.