Go: improve post-update node tests #20411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves testing for post-update nodes in Go data flow analysis by expanding test coverage to include method calls. The change reveals that post-update nodes are not generated for receivers of indirect method calls (calls made through variables), which is noted as future work to address.
Key changes:
- Enhanced the test query to display both post-update nodes and their corresponding pre-update nodes
- Added test cases for direct and indirect method calls to verify post-update node generation
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test.ql | Modified query to output pre-update nodes alongside post-update nodes for better test visibility |
| test.go | Added method definitions and test cases for direct/indirect method calls to expand test coverage |
| test.expected | Updated expected output to reflect the enhanced query results and new test cases |
igfoo
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should be testing post-update nodes for method calls. It turns out that we don't generate post-update nodes for receivers of method calls when they are made indirectly, via a variable. (The code looks like it tries to, but actually it will never work.) It won't always be possible to find the receiver, but when it is we probably ought to. But that is future work.