Skip to content

Go: improve post-update node tests #20411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 11, 2025
Merged

Go: improve post-update node tests #20411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cbbf7c2
Include pre-update node in output
owen-mc Sep 11, 2025
fa18fd2
Add method defs
owen-mc Sep 11, 2025
84e70e1
Add direct method calls
owen-mc Sep 11, 2025
d9e7c89
Add indirect method calls
owen-mc Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 26 additions & 15 deletions go/ql/test/library-tests/semmle/go/dataflow/PostUpdateNodes/test.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,26 @@
| test.go:19:2:19:2 | definition of a |
| test.go:20:11:20:14 | &... |
| test.go:20:12:20:14 | selection of b |
| test.go:21:2:21:5 | selection of bs |
| test.go:21:2:21:8 | index expression |
| test.go:21:17:21:20 | &... |
| test.go:21:18:21:20 | struct literal |
| test.go:22:2:22:5 | selection of bs |
| test.go:22:2:22:8 | index expression |
| test.go:22:2:22:13 | implicit dereference |
| test.go:22:2:22:13 | selection of cptr |
| test.go:23:2:23:7 | implicit dereference |
| test.go:23:2:23:7 | selection of bptr |
| test.go:23:2:23:12 | implicit dereference |
| test.go:23:2:23:12 | selection of cptr |
| file://:0:0:0:0 | [summary] to write: Argument[0] in copy | file://:0:0:0:0 | [summary param] 0 in copy |
| test.go:22:2:22:2 | definition of a | test.go:23:2:23:2 | a |
| test.go:22:2:22:2 | definition of a | test.go:24:2:24:2 | a |
| test.go:22:2:22:2 | definition of a | test.go:25:2:25:2 | a |
| test.go:22:2:22:2 | definition of a | test.go:26:2:26:2 | a |
| test.go:22:2:22:2 | definition of a | test.go:29:6:29:6 | a |
| test.go:22:2:22:2 | definition of a | test.go:30:7:30:7 | a |
| test.go:22:2:22:2 | definition of a | test.go:35:4:35:4 | a |
| test.go:22:2:22:2 | definition of a | test.go:36:5:36:5 | a |
| test.go:23:11:23:14 | &... | test.go:23:11:23:14 | &... |
| test.go:23:12:23:14 | selection of b | test.go:23:12:23:14 | selection of b |
| test.go:24:2:24:5 | selection of bs | test.go:24:2:24:5 | selection of bs |
| test.go:24:2:24:8 | index expression | test.go:24:2:24:8 | index expression |
| test.go:24:17:24:20 | &... | test.go:24:17:24:20 | &... |
| test.go:24:18:24:20 | struct literal | test.go:24:18:24:20 | struct literal |
| test.go:25:2:25:5 | selection of bs | test.go:25:2:25:5 | selection of bs |
| test.go:25:2:25:8 | index expression | test.go:25:2:25:8 | index expression |
| test.go:25:2:25:13 | implicit dereference | test.go:25:2:25:13 | implicit dereference |
| test.go:25:2:25:13 | selection of cptr | test.go:25:2:25:13 | selection of cptr |
| test.go:26:2:26:7 | implicit dereference | test.go:26:2:26:7 | implicit dereference |
| test.go:26:2:26:7 | selection of bptr | test.go:26:2:26:7 | selection of bptr |
| test.go:26:2:26:12 | implicit dereference | test.go:26:2:26:12 | implicit dereference |
| test.go:26:2:26:12 | selection of cptr | test.go:26:2:26:12 | selection of cptr |
| test.go:28:2:28:2 | definition of c | test.go:29:2:29:2 | c |
| test.go:28:2:28:2 | definition of c | test.go:30:2:30:2 | c |
| test.go:28:7:28:10 | struct literal | test.go:28:7:28:10 | struct literal |
12 changes: 12 additions & 0 deletions go/ql/test/library-tests/semmle/go/dataflow/PostUpdateNodes/test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ type C struct {
field int
}

func (c C) m(a A) {}
func (c *C) mp(a A) {}

type B struct {
cptr *C
}
Expand All @@ -22,4 +25,13 @@ func f() {
a.bs[3].cptr.field = 100
a.bptr.cptr.field = 101

c := C{0}
c.m(a)
c.mp(a)

// Indirect method calls - missing post-update nodes for the receivers
f := c.m
fp := c.mp
f(a)
fp(a)
}
2 changes: 1 addition & 1 deletion go/ql/test/library-tests/semmle/go/dataflow/PostUpdateNodes/test.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import go

from DataFlow::PostUpdateNode pun
select pun
select pun, pun.getPreUpdateNode()