Skip to content

Conversation

@jketema
Copy link
Contributor

@jketema jketema commented Sep 25, 2025

No description provided.

@github-actions github-actions bot added the C++ label Sep 25, 2025
@jketema jketema marked this pull request as ready for review September 25, 2025 08:08
@jketema jketema requested a review from a team as a code owner September 25, 2025 08:08
Copilot AI review requested due to automatic review settings September 25, 2025 08:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes a test case for the permissive mode in the C++ CodeQL library, along with its expected output files. The change appears to be cleaning up test files after extractor changes made the permissive mode test obsolete.

  • Removes the permissive.cpp test file containing a function with const-correctness issues
  • Removes the corresponding expected output files for calls and accesses queries

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
cpp/ql/test/library-tests/permissive/permissive.cpp Removes entire test file with permissive mode example
cpp/ql/test/library-tests/permissive/calls.expected Removes expected output for function calls in permissive test
cpp/ql/test/library-tests/permissive/accesses.expected Removes expected output for variable accesses in permissive test

Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the rest of the test (e.g. non_permissive.c) still have value?

@jketema
Copy link
Contributor Author

jketema commented Sep 25, 2025

Does the rest of the test (e.g. non_permissive.c) still have value?

I believe so. I think it's good to know that it still fails (as it should).

@jketema jketema merged commit 9dfd87c into github:main Sep 28, 2025
10 checks passed
@jketema jketema deleted the permissive branch September 28, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants