Java integration test: wait for test servers to come up before running test #20601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IdrissRio
force-pushed
the
idrissrio/java-localhost
branch
3 times, most recently
from
6027153 to
1b52b49
Compare
smowton
changed the title
IdrissRio
force-pushed
the
idrissrio/java-localhost
branch
from
1b52b49 to
546d59f
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes flaky Java integration tests on macOS by ensuring test HTTP servers are ready before running the tests. The main issue was that Maven would timeout when trying to connect to servers that hadn't fully started yet.
- Added a
wait_for_port()function to verify server connectivity before proceeding with tests - Modified subprocess creation to capture stderr/stdout to prevent output interference
- Added proper server readiness checks with timeout handling
java/ql/integration-tests/java/buildless-dependency-different-repository/test.py
Show resolved
Hide resolved
java/ql/integration-tests/java/buildless-dependency-different-repository/test.py
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes test failures on macOS 26 where Maven would timeout connecting to test HTTP servers that weren't ready yet.
The main change is the addition of the
wait_for_port()function that verifies if servers are accepting connections before running the tests.