From 0955457e8477672a4fded273e843c423c1489662 Mon Sep 17 00:00:00 2001 From: Asger F Date: Tue, 4 Nov 2025 08:51:46 +0100 Subject: [PATCH 1/2] Revert "JS: Recursively delete source archive so emptiness detection works" This reverts commit 0acfacefbfd9fbf1d0230c09d51afa5143c86e81. --- .../extractor/src/com/semmle/js/extractor/AutoBuild.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/javascript/extractor/src/com/semmle/js/extractor/AutoBuild.java b/javascript/extractor/src/com/semmle/js/extractor/AutoBuild.java index 8d00712b653b..f5e998398f52 100644 --- a/javascript/extractor/src/com/semmle/js/extractor/AutoBuild.java +++ b/javascript/extractor/src/com/semmle/js/extractor/AutoBuild.java @@ -498,9 +498,12 @@ public int run() throws IOException { // ensuring that the finalize steps detects that no code was seen. Path srcFolder = Paths.get(EnvironmentVariables.getWipDatabase(), "src"); try { - FileUtil8.recursiveDelete(srcFolder); + // Non-recursive delete because "src/" should be empty. + FileUtil8.delete(srcFolder); } catch (NoSuchFileException e) { Exceptions.ignore(e, "the directory did not exist"); + } catch (DirectoryNotEmptyException e) { + Exceptions.ignore(e, "just leave the directory if it is not empty"); } return 0; } From 7bb312de5a7e7dd892d49b0f96aeea87207df5e9 Mon Sep 17 00:00:00 2001 From: Asger F Date: Tue, 4 Nov 2025 08:52:06 +0100 Subject: [PATCH 2/2] Revert "JS: Add compileForOverlayEval" This reverts commit 39f74d808be5cf89c48ec805212ff23121fce217. --- javascript/ql/lib/qlpack.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/javascript/ql/lib/qlpack.yml b/javascript/ql/lib/qlpack.yml index d8d53ef1c7ef..1ee1c8c78150 100644 --- a/javascript/ql/lib/qlpack.yml +++ b/javascript/ql/lib/qlpack.yml @@ -23,4 +23,3 @@ dataExtensions: - semmle/javascript/security/domains/**/*.model.yml - ext/*.model.yml warnOnImplicitThis: true -compileForOverlayEval: true