Skip to content

Java: Sharpen return type of LambdaExpr.getStmtBody(). #3106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2020
Merged

Java: Sharpen return type of LambdaExpr.getStmtBody(). #3106

merged 1 commit into from
Mar 24, 2020

Conversation

aschackmull
Copy link
Contributor

Fixes #3104.

@aschackmull aschackmull requested a review from a team as a code owner March 23, 2020 09:29
@Marcono1234
Copy link
Contributor

Would it make sense to adjust the documentation of hasStmtBody and getStmtBody (since predicate names probably cannot be changed) to reflect this?
The JLS also talks about "block" and not statement.

@aschackmull
Copy link
Contributor Author

Well, a block is also a statement so the qldoc is still correct and unambiguous, so I think I slightly prefer it as-is.

@yo-h yo-h merged commit 116c13e into github:master Mar 24, 2020
@aschackmull aschackmull deleted the java/getstmtbody-type branch March 27, 2020 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yo-h yo-h yo-h approved these changes

Assignees
No one assigned
Labels
Java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Java: LambdaExpr.getStmtBody() should return Block, not Stmt
3 participants
@aschackmull @Marcono1234 @yo-h