JS: Add withoutPropStep and model raw 'await' step with it #9616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asgerf
added
JS
Awaiting evaluation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
asgerf
force-pushed
the
js/without-prop-step-await
branch
2 times, most recently
from
2d58260 to
654d687
Compare
asgerf
removed
the
Awaiting evaluation
asgerf
force-pushed
the
js/without-prop-step-await
branch
from
654d687 to
835c9bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing
await xon non-promise value just returnsxitself, but our type-tracking steps didn't take this into account, leading to missed flow.This PR adds support for this by adding
PropertySetandwithoutPropStep(Node pred, Node succ, PropertySet props). This steps allows flow frompred -> succbut without the properties inprops(see qldoc in PR).This new step is deliberately similar to the
WithoutElementstep that @hvitved added in #8938. (TheWithElementstep is called aloadStoreStepin JS)Evaluation was quiet